Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: chrome/browser/resources/settings/languages_page/manage_languages_page.html

Issue 1902893003: MD Settings: simplify language model and data binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comment based on other CL feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/manage_languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/manage_languages_page.html b/chrome/browser/resources/settings/languages_page/manage_languages_page.html
index 1785d6c1c64ef1c0477d8f919112d178067880db..ba6dd4a5607f187db713e50eee987a578f87e7b8 100644
--- a/chrome/browser/resources/settings/languages_page/manage_languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/manage_languages_page.html
@@ -22,38 +22,35 @@
}
</style>
<settings-languages languages="{{languages}}"></settings-languages>
- <div class="settings-box first content">
- <div class="start">
- <h2>$i18n{enabledLanguages}</h2>
- <div class="list-frame vertical-list">
- <template is="dom-repeat" items="{{languages.enabledLanguages}}">
+ <div class="settings-box first block">
+ <h2>$i18n{enabledLanguages}</h2>
+ <div class="list-frame vertical-list">
+ <template is="dom-repeat" items="{{languages.enabled}}">
+ <div class="list-item">
+ <div class="start" title="[[item.language.nativeDisplayName]]">
+ [[item.language.displayName]]
+ </div>
+ <paper-icon-button icon="clear" on-tap="onRemoveLanguageTap_"
+ hidden$="[[!item.removable]]">
+ </paper-icon-button>
+ </div>
+ </template>
+ </div>
+ <h2>$i18n{allLanguages}</h2>
+ <div class="list-frame vertical-list">
+ <iron-list items="{{languages.supported}}">
+ <template>
<div class="list-item">
- <div class="start" title="[[item.language.nativeDisplayName]]">
- [[item.language.displayName]]
- </div>
- <paper-icon-button icon="clear" on-tap="onRemoveLanguageTap_"
- hidden$="[[!canRemoveLanguage_(
- item.language.code, prefs.intl.app_locale.value)]]">
- </paper-icon-button>
+ <paper-checkbox
+ checked="[[isCheckboxChecked_(item, languages.enabled.*)]]"
+ disabled="[[isLanguageRequired_(item, languages.enabled.*)]]"
+ title$="[[item.nativeDisplayName]]"
+ on-change="onLanguageCheckboxChange_">
+ [[item.displayName]]
+ </paper-checkbox>
</div>
</template>
- </div>
- <h2>$i18n{allLanguages}</h2>
- <div class="list-frame vertical-list">
- <iron-list items="{{availableLanguages_}}" as="item">
- <template>
- <div class="list-item">
- <paper-checkbox checked="[[item.enabled]]"
- title$="[[item.nativeDisplayName]]"
- disabled="[[!canRemoveLanguage_(
- item.code, prefs.intl.app_locale.value)]]"
- on-change="onLanguageCheckboxChange_">
- [[item.displayName]]
- </paper-checkbox>
- </div>
- </template>
- </iron-list>
- </div>
+ </iron-list>
</div>
</div>
</template>

Powered by Google App Engine
This is Rietveld 408576698