Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: chrome/browser/resources/settings/languages_page/language_detail_page.js

Issue 1902893003: MD Settings: simplify language model and data binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/language_detail_page.js
diff --git a/chrome/browser/resources/settings/languages_page/language_detail_page.js b/chrome/browser/resources/settings/languages_page/language_detail_page.js
index 4212bf2e4541df1494be2cfe4e5b81db0b795843..921aed659f45b6e8acda32acd5187a87cf241cf4 100644
--- a/chrome/browser/resources/settings/languages_page/language_detail_page.js
+++ b/chrome/browser/resources/settings/languages_page/language_detail_page.js
@@ -21,13 +21,13 @@ Polymer({
/**
* Read-only reference to the languages model provided by the
* 'settings-languages' instance.
- * @type {LanguagesModel|undefined}
+ * @type {!LanguagesModel|undefined}
*/
languages: Object,
/**
* The language to display the details for.
- * @type {LanguageInfo|undefined}
+ * @type {!LanguageState|undefined}
*/
detail: Object,
@@ -57,7 +57,6 @@ Polymer({
}
},
-<if expr="chromeos or is_win">
/**
* Checks whether the prospective UI language (the pref that indicates what
* language to use in Chrome) matches the current language. This pref is only
@@ -69,6 +68,7 @@ Polymer({
* @private
*/
isProspectiveUILanguage_: function(languageCode, prospectiveUILanguage) {
+ assert(cr.isChromeOS || cr.isWindows);
return languageCode == this.languageHelper_.getProspectiveUILanguage();
},
@@ -80,10 +80,10 @@ Polymer({
* @private
*/
isCurrentUILanguage_: function(languageCode, prospectiveUILanguage) {
+ assert(cr.isChromeOS || cr.isWindows);
return languageCode == prospectiveUILanguage &&
languageCode == navigator.language;
},
-</if>
/**
* @param {string} languageCode The language code identifying a language.

Powered by Google App Engine
This is Rietveld 408576698