Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: chrome/test/data/webui/settings/languages_page_tests.js

Issue 1902893003: MD Settings: simplify language model and data binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comment based on other CL feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/languages_page/manage_languages_page.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('settings_languages_page', function() { 5 cr.define('settings_languages_page', function() {
6 suite('settings-languages-singleton', function() { 6 suite('settings-languages-singleton', function() {
7 var languageSettingsPrivate; 7 var languageSettingsPrivate;
8 var languageHelper; 8 var languageHelper;
9 var settingsPrefs; 9 var settingsPrefs;
10 var fakePrefs = [{ 10 var fakePrefs = [{
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 languageSettingsPrivate.setSettingsPrefs(settingsPrefs); 58 languageSettingsPrivate.setSettingsPrefs(settingsPrefs);
59 LanguageHelperImpl.instance_ = undefined; 59 LanguageHelperImpl.instance_ = undefined;
60 languageHelper = LanguageHelperImpl.getInstance(); 60 languageHelper = LanguageHelperImpl.getInstance();
61 return languageHelper.whenReady(); 61 return languageHelper.whenReady();
62 }); 62 });
63 63
64 test('languages model', function() { 64 test('languages model', function() {
65 for (var i = 0; i < languageSettingsPrivate.languages.length; 65 for (var i = 0; i < languageSettingsPrivate.languages.length;
66 i++) { 66 i++) {
67 assertEquals(languageSettingsPrivate.languages[i].code, 67 assertEquals(languageSettingsPrivate.languages[i].code,
68 languageHelper.languages.supportedLanguages[i].code); 68 languageHelper.languages.supported[i].code);
69 } 69 }
70 assertEquals(2, languageHelper.languages.enabledLanguages.length); 70 assertEquals(2, languageHelper.languages.enabled.length);
71 assertEquals('en-US', 71 assertEquals('en-US',
72 languageHelper.languages.enabledLanguages[0].language.code); 72 languageHelper.languages.enabled[0].language.code);
73 assertEquals('sw', 73 assertEquals('sw',
74 languageHelper.languages.enabledLanguages[1].language.code); 74 languageHelper.languages.enabled[1].language.code);
75 assertEquals('en', languageHelper.languages.translateTarget); 75 assertEquals('en', languageHelper.languages.translateTarget);
76 76
77 // TODO(michaelpg): Test other aspects of the model. 77 // TODO(michaelpg): Test other aspects of the model.
78 }); 78 });
79 79
80 test('modifying languages', function() { 80 test('modifying languages', function() {
81 assertTrue(languageHelper.isLanguageEnabled('en-US')); 81 assertTrue(languageHelper.isLanguageEnabled('en-US'));
82 assertTrue(languageHelper.isLanguageEnabled('sw')); 82 assertTrue(languageHelper.isLanguageEnabled('sw'));
83 assertFalse(languageHelper.isLanguageEnabled('en-CA')); 83 assertFalse(languageHelper.isLanguageEnabled('en-CA'));
84 84
85 languageHelper.enableLanguage('en-CA'); 85 languageHelper.enableLanguage('en-CA');
86 assertTrue(languageHelper.isLanguageEnabled('en-CA')); 86 assertTrue(languageHelper.isLanguageEnabled('en-CA'));
87 languageHelper.disableLanguage('sw'); 87 languageHelper.disableLanguage('sw');
88 assertFalse(languageHelper.isLanguageEnabled('sw')); 88 assertFalse(languageHelper.isLanguageEnabled('sw'));
89 89
90 // TODO(michaelpg): Test other modifications. 90 // TODO(michaelpg): Test other modifications.
91 }); 91 });
92 }); 92 });
93 }); 93 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/languages_page/manage_languages_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698