[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Adds a Generate method to the stubs that can be used to embed the graph directly in the bytecode handlers.

Committed: https://crrev.com/e8caf78ff2a9f7d50ac9b47f6b4c80f92b69914a
Cr-Commit-Position: refs/heads/master@{#35696}

[epertoso, 2016-04-20 08:17:10]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-04-20 08:42:33]

LGTM with comment.

https://codereview.chromium.org/1902823002/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1902823002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:710: void Interpreter::DoBinaryOp(Node*
(*generator)(CodeStubAssembler*, Node*,
Please no naked function pointers here, as discussed offline :-)

[rmcilroy, 2016-04-20 08:56:58]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-04-20 08:56:58]

Interpreter changes look good to me, but +1 to Benedkit's comment.

[epertoso, 2016-04-20 08:59:50]

Took care of the function pointer.

https://codereview.chromium.org/1902823002/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/1902823002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:710: void Interpreter::DoBinaryOp(Node*
(*generator)(CodeStubAssembler*, Node*,
On 2016/04/20 at 08:42:33, Benedikt Meurer wrote:
> Please no naked function pointers here, as discussed offline :-)

Done.

[epertoso, 2016-04-20 13:16:55]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-04-20 13:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1902823002/#ps40001
(title: "Update")

[commit-bot: I haz the power, 2016-04-20 13:17:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902823002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902823002/40001

[commit-bot: I haz the power, 2016-04-20 13:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 13:20:11]

Try jobs failed on following builders:
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/441)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4567)

[epertoso, 2016-04-21 09:26:19]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 09:26:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902823002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902823002/60001

[commit-bot: I haz the power, 2016-04-21 09:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 09:37:44]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Michael Achenbach, 2016-04-21 09:48:52]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 09:49:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902823002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902823002/60001

[Michael Achenbach, 2016-04-21 09:49:05]

Description was changed from

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Adds a Generate method to the stubs that can be used to embed the graph directly
in the bytecode handlers.
==========

to

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Adds a Generate method to the stubs that can be used to embed the graph directly
in the bytecode handlers.
==========

[Michael Achenbach, 2016-04-21 09:49:05]

machenbach@chromium.org changed reviewers:
- machenbach@chromium.org

[commit-bot: I haz the power, 2016-04-21 09:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 09:58:17]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Michael Achenbach, 2016-04-21 09:58:52]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 09:59:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902823002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902823002/60001

[commit-bot: I haz the power, 2016-04-21 10:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 10:13:20]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-04-21 10:13:50]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-04-21 10:13:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1902823002/#ps60001
(title: "Update")

[commit-bot: I haz the power, 2016-04-21 10:13:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902823002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902823002/60001

[commit-bot: I haz the power, 2016-04-21 10:16:18]

Description was changed from

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Adds a Generate method to the stubs that can be used to embed the graph directly
in the bytecode handlers.
==========

to

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Adds a Generate method to the stubs that can be used to embed the graph directly
in the bytecode handlers.
==========

[commit-bot: I haz the power, 2016-04-21 10:16:20]

Committed patchset #4 (id:60001)

[Michael Achenbach, 2016-04-21 11:37:07]

FYI: Breaks greedy allocator:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20...

CC: mtrofin

[commit-bot: I haz the power, 2016-04-22 19:14:29]

Description was changed from

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Adds a Generate method to the stubs that can be used to embed the graph directly
in the bytecode handlers.
==========

to

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Adds a Generate method to the stubs that can be used to embed the graph directly
in the bytecode handlers.

Committed: https://crrev.com/e8caf78ff2a9f7d50ac9b47f6b4c80f92b69914a
Cr-Commit-Position: refs/heads/master@{#35696}
==========

[commit-bot: I haz the power, 2016-04-22 19:14:31]

Patchset 4 (id:??) landed as
https://crrev.com/e8caf78ff2a9f7d50ac9b47f6b4c80f92b69914a
Cr-Commit-Position: refs/heads/master@{#35696}

[epertoso, 2016-04-28 08:38:25]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1927873002/ by epertoso@chromium.org.

The reason for reverting is: Caused a performance regression in TurboFan and did
not improve in a significant way Ignition's performances..