Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902753002: Serialize more native data. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -18 lines) Patch
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 3 chunks +35 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +0 lines, -5 lines 1 comment Download
M tests/compiler/dart2js/serialization_model_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/1902753002/diff/1/pkg/compiler/lib/src/js_emitter/native_emitter.dart File pkg/compiler/lib/src/js_emitter/native_emitter.dart (left): https://codereview.chromium.org/1902753002/diff/1/pkg/compiler/lib/src/js_emitter/native_emitter.dart#oldcode38 pkg/compiler/lib/src/js_emitter/native_emitter.dart:38: jsAst.Expression get defPropFunction { Unused (found while investigating why ...
4 years, 8 months ago (2016-04-19 11:04:59 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 8 months ago (2016-04-19 20:34:49 UTC) #3
Johnni Winther
4 years, 8 months ago (2016-04-20 08:30:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7c20fa24d257ae735854054d569855f7075fbb85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698