Cleanups from prior CLs.

Cleanups from prior CLs.

This cleans up the Initialize methods and the ownership in CPDF_Creator.

Committed: https://pdfium.googlesource.com/pdfium/+/a5532791cbe6e931338ea98c612c8bb6bc74f712

[dsinclair, 2016-04-19 18:52:57]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-19 18:52:58]

PTAL.

[Lei Zhang, 2016-04-19 19:16:39]

https://codereview.chromium.org/1902713003/diff/20001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1902713003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:502: m_bNewBuf = FALSE;
No need to set to FALSE again.

https://codereview.chromium.org/1902713003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:910:
m_pCryptoHandler.reset(m_pParser->GetCryptoHandler());
I'm a bit worried about who actually owns the pointer.

https://codereview.chromium.org/1902713003/diff/20001/xfa/fxfa/parser/xfa_bas...
File xfa/fxfa/parser/xfa_basic_imp.cpp (right):

https://codereview.chromium.org/1902713003/diff/20001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_imp.cpp:375: XFA_SCRIPTHIERARCHY const* scriptIndex =
g_XFAScriptIndex + iElementIndex;
Same here.

[dsinclair, 2016-04-19 19:50:22]

PTAL.

I removed the unique_ptr for the crypto handler. If the case where it's set from
the syntax parser, it's owned by the parser, in the case where it sets it
locally by creating a new one it's owned locally ....

https://codereview.chromium.org/1902713003/diff/20001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1902713003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:502: m_bNewBuf = FALSE;
On 2016/04/19 19:16:39, Lei Zhang wrote:
> No need to set to FALSE again.

Done.

https://codereview.chromium.org/1902713003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:910:
m_pCryptoHandler.reset(m_pParser->GetCryptoHandler());
On 2016/04/19 19:16:39, Lei Zhang wrote:
> I'm a bit worried about who actually owns the pointer.


You're right, this is broken.

https://codereview.chromium.org/1902713003/diff/20001/xfa/fxfa/parser/xfa_bas...
File xfa/fxfa/parser/xfa_basic_imp.cpp (right):

https://codereview.chromium.org/1902713003/diff/20001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_imp.cpp:375: XFA_SCRIPTHIERARCHY const* scriptIndex =
g_XFAScriptIndex + iElementIndex;
On 2016/04/19 19:16:39, Lei Zhang wrote:
> Same here.

Done.

[Tom Sepez, 2016-04-19 20:48:21]

https://codereview.chromium.org/1902713003/diff/40001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1902713003/diff/40001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:398: uint8_t* m_pData;
nit: blank line between methods&members

[Lei Zhang, 2016-04-19 21:12:28]

lgtm

[dsinclair, 2016-04-20 13:09:12]

https://codereview.chromium.org/1902713003/diff/40001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1902713003/diff/40001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:398: uint8_t* m_pData;
On 2016/04/19 20:48:21, Tom Sepez wrote:
> nit: blank line between methods&members

Done.

[dsinclair, 2016-04-20 13:09:16]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-20 13:09:16]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1902713003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-20 13:09:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902713003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902713003/60001

[commit-bot: I haz the power, 2016-04-20 13:24:15]

Description was changed from

==========
Cleanups from prior CLs.

This cleans up the Initialize methods and the ownership in CPDF_Creator.
==========

to

==========
Cleanups from prior CLs.

This cleans up the Initialize methods and the ownership in CPDF_Creator.

Committed:
https://pdfium.googlesource.com/pdfium/+/a5532791cbe6e931338ea98c612c8bb6bc74...
==========

[commit-bot: I haz the power, 2016-04-20 13:24:21]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/a5532791cbe6e931338ea98c612c8bb6bc74...