Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2491)

Unified Diff: chrome/browser/notifications/notification_ui_manager_impl.h

Issue 19027005: Hide notifications popups when entering fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix remaining testing issues Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_ui_manager_impl.h
diff --git a/chrome/browser/notifications/notification_ui_manager_impl.h b/chrome/browser/notifications/notification_ui_manager_impl.h
index a56d439a55c51e9c53fc19c95bd221475694f87c..23e0a782dd017a0f9ceff321c00d9be7328e62e8 100644
--- a/chrome/browser/notifications/notification_ui_manager_impl.h
+++ b/chrome/browser/notifications/notification_ui_manager_impl.h
@@ -58,23 +58,23 @@ class NotificationUIManagerImpl
Profile* profile) = 0;
// Replace an existing notification of the same id with this one if
- // applicable; subclass returns 'true' if the replacement happened.
+ // applicable. Subclass returns 'true' if the replacement happened.
virtual bool UpdateNotification(const Notification& notification,
Profile* profile) = 0;
- // Attempts to display notifications from the show_queue. Invoked by subclass
- // if it previously returned 'false' from ShowNotifications, which may happen
- // when there is no room to show another notification. When room appears, the
- // subclass should call this method to cause an attempt to show more
- // notifications from the waiting queue.
+ // Attempts to display notifications from the show_queue. Invoked by
+ // subclasses if they previously returned 'false' from ShowNotifications,
+ // which may happen when there is no room to show another notification. When
+ // room appears, the subclass should call this method to cause an attempt to
+ // show more notifications from the waiting queue.
void CheckAndShowNotifications();
- private:
// content::NotificationObserver override.
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ private:
// Attempts to display notifications from the show_queue.
void ShowNotifications();

Powered by Google App Engine
This is Rietveld 408576698