Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: ash/wm/workspace/workspace_manager.cc

Issue 19027005: Hide notifications popups when entering fullscreen mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add ChromeOS support. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace/workspace_manager.cc
diff --git a/ash/wm/workspace/workspace_manager.cc b/ash/wm/workspace/workspace_manager.cc
index ffed0dc0ebc4688e24aa1153b75ef72a08b304f3..fab8bb4009be461af4bfce1e46da72ab5e718c1f 100644
--- a/ash/wm/workspace/workspace_manager.cc
+++ b/ash/wm/workspace/workspace_manager.cc
@@ -9,6 +9,7 @@
#include "ash/root_window_controller.h"
#include "ash/shelf/shelf_layout_manager.h"
+#include "ash/shelf/shelf_widget.h"
#include "ash/shell.h"
#include "ash/shell_window_ids.h"
#include "ash/wm/base_layout_manager.h"
@@ -690,6 +691,18 @@ void WorkspaceManager::OnWorkspaceWindowShowStateChanged(
pending_workspaces_.insert(new_workspace);
ReparentWindow(child, new_workspace->window(), NULL);
}
+ if (full_count > 0) {
Jun Mukai 2013/07/13 00:51:16 It is not very good to hook just here. Instead, be
+ // Hide notifications if there are fullscreen windows.
+ Shell::RootWindowControllerList controllers =
+ Shell::GetAllRootWindowControllers();
+ Shell::RootWindowControllerList::iterator iter = controllers.begin();
+ for ( ; iter != controllers.end(); iter++) {
+ (*iter)->shelf()->status_area_widget()->SetHideWebNotifications(
+ true);
+ }
+ }
+
+
if (is_active && new_workspace) {
// |old_layer| may be NULL if as part of processing
// WorkspaceLayoutManager::OnWindowPropertyChanged() the window is made
@@ -715,6 +728,7 @@ void WorkspaceManager::OnWorkspaceWindowShowStateChanged(
}
}
UpdateShelfVisibility();
+
}
void WorkspaceManager::OnTrackedByWorkspaceChanged(Workspace* workspace,

Powered by Google App Engine
This is Rietveld 408576698