Switch Android Builder on chromium.webkit to gn.

Switch Android Builder on chromium.webkit to gn.

BUG=604468
Committed: https://crrev.com/16d24abd98d2b5c87d2065ae29d27ea98ac92e51
Cr-Commit-Position: refs/heads/master@{#388383}

[jbudorick, 2016-04-19 22:05:17]

jbudorick@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-19 22:12:58]

lgtm if you're willing to make the other changes I describe and be more
aggressive :).

https://codereview.chromium.org/1902643003/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1902643003/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:544: 'WebKit Android (Nexus4)': 'none',
So you're going to make Android Builder trigger WebKit Android (Nexus4) via some
build-side change?

Hopefully it'll pull in all of the right targets ...

I'd be more inclined to just flip both bots to GN now, and change to triggering
in a separate change.

[jbudorick, 2016-04-19 22:17:51]

https://codereview.chromium.org/1902643003/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1902643003/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:544: 'WebKit Android (Nexus4)': 'none',
On 2016/04/19 22:12:58, Dirk Pranke wrote:
> So you're going to make Android Builder trigger WebKit Android (Nexus4) via
some
> build-side change?
> 
> Hopefully it'll pull in all of the right targets ...
> 
> I'd be more inclined to just flip both bots to GN now, and change to
triggering
> in a separate change.

I'm confused -- WebKit Android (Nexus4) already appears to be triggered by
Android Builder:
https://chromium.googlesource.com/chromium/tools/build/+/master/masters/maste...

[Dirk Pranke, 2016-04-19 23:02:31]

Ah, you're right. I was misremembering and thinking of something from long ago
when it wasn't, I guess.

[jbudorick, 2016-04-19 23:34:49]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-04-19 23:35:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902643003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902643003/1

[commit-bot: I haz the power, 2016-04-20 00:44:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:19:09]

Description was changed from

==========
Switch Android Builder on chromium.webkit to gn.

BUG=604468
==========

to

==========
Switch Android Builder on chromium.webkit to gn.

BUG=604468

Committed: https://crrev.com/16d24abd98d2b5c87d2065ae29d27ea98ac92e51
Cr-Commit-Position: refs/heads/master@{#388383}
==========

[commit-bot: I haz the power, 2016-04-22 19:19:10]

Patchset 1 (id:??) landed as
https://crrev.com/16d24abd98d2b5c87d2065ae29d27ea98ac92e51
Cr-Commit-Position: refs/heads/master@{#388383}

[jbudorick, 2016-04-25 21:16:14]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1915853005/ by jbudorick@chromium.org.

The reason for reverting is: too many gn issues..

[Dirk Pranke, 2016-04-25 21:19:46]

On 2016/04/25 21:16:14, jbudorick wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1915853005/ by mailto:jbudorick@chromium.org.
> 
> The reason for reverting is: too many gn issues..

What sorts of issues?

[jbudorick, 2016-04-25 21:21:40]

On 2016/04/25 21:19:46, Dirk Pranke wrote:
> On 2016/04/25 21:16:14, jbudorick wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1915853005/ by
mailto:jbudorick@chromium.org.
> > 
> > The reason for reverting is: too many gn issues..
> 
> What sorts of issues?

so far:
 - the symlink one
 - forwarder is built as a host executable, which is wrong
 - content_shell_apk crashes on start with a failure to find
NestedSystemMessageHandler

I'm working through them, but it seems prudent to switch the bot back to gyp
while doing so.

[Dirk Pranke, 2016-04-25 21:22:55]

On 2016/04/25 21:21:40, jbudorick wrote:
> On 2016/04/25 21:19:46, Dirk Pranke wrote:
> > On 2016/04/25 21:16:14, jbudorick wrote:
> > > A revert of this CL (patchset #1 id:1) has been created in
> > > https://codereview.chromium.org/1915853005/ by
> mailto:jbudorick@chromium.org.
> > > 
> > > The reason for reverting is: too many gn issues..
> > 
> > What sorts of issues?
> 
> so far:
>  - the symlink one
>  - forwarder is built as a host executable, which is wrong
>  - content_shell_apk crashes on start with a failure to find
> NestedSystemMessageHandler
> 
> I'm working through them, but it seems prudent to switch the bot back to gyp
> while doing so.

Ack, sounds good.