Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1902593004: Remove webrtc::DesktopCapturer::Callback::CreateSharedMemory() overrides. (Closed)

Created:
4 years, 8 months ago by Sergey Ulanov
Modified:
4 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove webrtc::DesktopCapturer::Callback::CreateSharedMemory() overrides. CreateSharedMemory() has been deprecated and no longer needs to be overridden in DesktopCapturer::Callback implementations. Committed: https://crrev.com/4622a1c536fc2daed59d6de9f6e79fb84ee19f5e Cr-Commit-Position: refs/heads/master@{#388561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M remoting/protocol/video_frame_pump.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/video_frame_pump.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/protocol/webrtc_frame_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/webrtc_frame_scheduler.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
4 years, 8 months ago (2016-04-20 17:41:33 UTC) #2
Jamie
lgtm
4 years, 8 months ago (2016-04-20 18:41:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902593004/1
4 years, 8 months ago (2016-04-20 18:43:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 20:07:07 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4622a1c536fc2daed59d6de9f6e79fb84ee19f5e
Cr-Commit-Position: refs/heads/master@{#388561}

Powered by Google App Engine
This is Rietveld 408576698