[Mac/GN] Do not specify any default_libs to link.

[Mac/GN] Do not specify any default_libs to link.

This is the wrong thing to do. Targets should have control over what they link,
since adding frameworks can have run-time side effects. The only library that is
required is libSystem.dylib, but the linker implicitly adds that unless it
is creating a static executable.

BUG=431177
Committed: https://crrev.com/4806ea270d3151fddb36117261fbebb28ecbb2c4
Cr-Commit-Position: refs/heads/master@{#389111}

[Robert Sesek, 2016-04-19 19:22:44]

Description was changed from

==========
[Mac/GN] Do not specify any default_libs to link.

This is the wrong thing to do. Targets should have control over what they link,
since adding frameworks can have runtime side effects. The only library that is
required is libSystem.dylib, but the linker implicitly adds that unless it
is creating a static executable.

BUG=431177
==========

to

==========
[Mac/GN] Do not specify any default_libs to link.

This is the wrong thing to do. Targets should have control over what they link,
since adding frameworks can have run-time side effects. The only library that is
required is libSystem.dylib, but the linker implicitly adds that unless it
is creating a static executable.

BUG=431177
==========

[Robert Sesek, 2016-04-21 17:40:03]

rsesek@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-21 17:41:42]

lgtm. You'll still need OWNERS reviews for //base and //ui, though.

[Robert Sesek, 2016-04-21 17:42:20]

rsesek@chromium.org changed reviewers:
+ mark@chromium.org

[Robert Sesek, 2016-04-21 17:42:21]

+mark for //base OWNERS

[Mark Mentovai, 2016-04-21 18:28:44]

Obvious LGTM

[Robert Sesek, 2016-04-22 14:41:13]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2016-04-22 14:41:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902593003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902593003/1

[commit-bot: I haz the power, 2016-04-22 15:26:50]

Description was changed from

==========
[Mac/GN] Do not specify any default_libs to link.

This is the wrong thing to do. Targets should have control over what they link,
since adding frameworks can have run-time side effects. The only library that is
required is libSystem.dylib, but the linker implicitly adds that unless it
is creating a static executable.

BUG=431177
==========

to

==========
[Mac/GN] Do not specify any default_libs to link.

This is the wrong thing to do. Targets should have control over what they link,
since adding frameworks can have run-time side effects. The only library that is
required is libSystem.dylib, but the linker implicitly adds that unless it
is creating a static executable.

BUG=431177
==========

[commit-bot: I haz the power, 2016-04-22 15:26:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:47:38]

Description was changed from

==========
[Mac/GN] Do not specify any default_libs to link.

This is the wrong thing to do. Targets should have control over what they link,
since adding frameworks can have run-time side effects. The only library that is
required is libSystem.dylib, but the linker implicitly adds that unless it
is creating a static executable.

BUG=431177
==========

to

==========
[Mac/GN] Do not specify any default_libs to link.

This is the wrong thing to do. Targets should have control over what they link,
since adding frameworks can have run-time side effects. The only library that is
required is libSystem.dylib, but the linker implicitly adds that unless it
is creating a static executable.

BUG=431177

Committed: https://crrev.com/4806ea270d3151fddb36117261fbebb28ecbb2c4
Cr-Commit-Position: refs/heads/master@{#389111}
==========

[commit-bot: I haz the power, 2016-04-22 19:47:39]

Patchset 1 (id:??) landed as
https://crrev.com/4806ea270d3151fddb36117261fbebb28ecbb2c4
Cr-Commit-Position: refs/heads/master@{#389111}