Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902573002: [DevTools] Add test for step over function with caught exception (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add test for step over function with caught exception BUG=604495 R=lushnikov@chromium.org Committed: https://crrev.com/dc3b802c6de47fa18e77ee17f34b569cc2319213 Cr-Commit-Position: refs/heads/master@{#388592}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kozy
please take a look.
4 years, 8 months ago (2016-04-18 21:19:22 UTC) #1
lushnikov
why don't we fix it immediately?
4 years, 8 months ago (2016-04-19 01:59:29 UTC) #2
kozy
On 2016/04/19 01:59:29, lushnikov wrote: > why don't we fix it immediately? It's V8 issue. ...
4 years, 8 months ago (2016-04-19 03:06:23 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/1902573002/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html File third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html (right): https://codereview.chromium.org/1902573002/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html#newcode41 third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html:41: else nit: remove if-else
4 years, 8 months ago (2016-04-19 18:35:39 UTC) #4
kozy
All done. https://codereview.chromium.org/1902573002/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html File third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html (right): https://codereview.chromium.org/1902573002/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html#newcode41 third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html:41: else On 2016/04/19 18:35:39, lushnikov wrote: > ...
4 years, 8 months ago (2016-04-19 18:44:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902573002/40001
4 years, 8 months ago (2016-04-20 20:50:54 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-20 23:26:21 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:27:12 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/dc3b802c6de47fa18e77ee17f34b569cc2319213
Cr-Commit-Position: refs/heads/master@{#388592}

Powered by Google App Engine
This is Rietveld 408576698