Do not break after ZWJ if the trailing character is Emoji.

Do not break after ZWJ if the trailing character is Emoji.

Vendor may want to introduce their own ZWJ sequence.
To handle any kind of ZWJ joiner sequence, do not break the
grapheme cluster after ZWJ. Similary, need to delete emoji
before and after ZWJ at the same time by single backspace key.

BUG=594923
BUG=594920
Committed: https://crrev.com/d54a5cbde82b8238e55fcd1450c0d838acd9fab9
Cr-Commit-Position: refs/heads/master@{#388455}

[Seigo Nonaka, 2016-04-19 11:22:26]

Description was changed from

==========
Do not break after ZWJ if the trailing character is Emoji.

Vendor may want to introduce their own ZWJ sequence.
To handle any kind of ZWJ joiner sequence, do not break the
grapheme cluster after ZWJ. Similary, need to delete emoji
before and after ZWJ at the same time by single backspace key.
==========

to

==========
Do not break after ZWJ if the trailing character is Emoji.

Vendor may want to introduce their own ZWJ sequence.
To handle any kind of ZWJ joiner sequence, do not break the
grapheme cluster after ZWJ. Similary, need to delete emoji
before and after ZWJ at the same time by single backspace key.

BUG=594923
BUG=594920
==========

[Seigo Nonaka, 2016-04-19 11:26:12]

nona@chromium.org changed reviewers:
+ yosin@chromium.org

[Seigo Nonaka, 2016-04-19 11:26:13]

Hi Yosi-san,

Could you kindly take a look?

Some vendor may want to support their own ZWJ.
This CL is necessary for handling such kind of ZWJ sequence.

For example, Microsoft is now introducing Windows only Emoji which is non
standard ZWJ sequence in Unicode.

Thank you.

[yosin_UTC9, 2016-04-20 01:46:26]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-04-20 01:46:26]

lgtm

Thanks for quick work!

+tkent@ for platform/text chagnes

BTW, you can request to merge this patch into M51 with "Merge-Request-M51" label
in crbug.com.

[tkent, 2016-04-20 01:56:28]

lgtm

https://codereview.chromium.org/1902553004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/text/Character.h (right):

https://codereview.chromium.org/1902553004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/text/Character.h:115: static bool
isEmoji(UChar32);
Need a comment.  Difference between isEmoji and following functions looks
unclear to me.

[Seigo Nonaka, 2016-04-20 07:39:41]

Thank you for your quick review!
Submitting...

https://codereview.chromium.org/1902553004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/text/Character.h (right):

https://codereview.chromium.org/1902553004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/text/Character.h:115: static bool
isEmoji(UChar32);
On 2016/04/20 01:56:28, tkent wrote:
> Need a comment.  Difference between isEmoji and following functions looks
> unclear to me.

Done.

[Seigo Nonaka, 2016-04-20 07:39:44]

The CQ bit was checked by nona@chromium.org

[Seigo Nonaka, 2016-04-20 07:39:45]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1902553004/#ps20001
(title: "Add comment to isEmoji method")

[commit-bot: I haz the power, 2016-04-20 07:39:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902553004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902553004/20001

[Seigo Nonaka, 2016-04-20 09:40:20]

Forgot replying to yosi-san's comment.

I don't think this is urgent issue since Windows only emoji is still only in
Windows insider preview, so it is not too late for M52 :)

Thank you for letting me know.

[commit-bot: I haz the power, 2016-04-20 09:40:57]

Description was changed from

==========
Do not break after ZWJ if the trailing character is Emoji.

Vendor may want to introduce their own ZWJ sequence.
To handle any kind of ZWJ joiner sequence, do not break the
grapheme cluster after ZWJ. Similary, need to delete emoji
before and after ZWJ at the same time by single backspace key.

BUG=594923
BUG=594920
==========

to

==========
Do not break after ZWJ if the trailing character is Emoji.

Vendor may want to introduce their own ZWJ sequence.
To handle any kind of ZWJ joiner sequence, do not break the
grapheme cluster after ZWJ. Similary, need to delete emoji
before and after ZWJ at the same time by single backspace key.

BUG=594923
BUG=594920
==========

[commit-bot: I haz the power, 2016-04-20 09:40:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:21:58]

Description was changed from

==========
Do not break after ZWJ if the trailing character is Emoji.

Vendor may want to introduce their own ZWJ sequence.
To handle any kind of ZWJ joiner sequence, do not break the
grapheme cluster after ZWJ. Similary, need to delete emoji
before and after ZWJ at the same time by single backspace key.

BUG=594923
BUG=594920
==========

to

==========
Do not break after ZWJ if the trailing character is Emoji.

Vendor may want to introduce their own ZWJ sequence.
To handle any kind of ZWJ joiner sequence, do not break the
grapheme cluster after ZWJ. Similary, need to delete emoji
before and after ZWJ at the same time by single backspace key.

BUG=594923
BUG=594920

Committed: https://crrev.com/d54a5cbde82b8238e55fcd1450c0d838acd9fab9
Cr-Commit-Position: refs/heads/master@{#388455}
==========

[commit-bot: I haz the power, 2016-04-22 19:21:59]

Patchset 2 (id:??) landed as
https://crrev.com/d54a5cbde82b8238e55fcd1450c0d838acd9fab9
Cr-Commit-Position: refs/heads/master@{#388455}