Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1902513002: Add type and icon to credit card object in Java (Closed)

Created:
4 years, 8 months ago by please use gerrit instead
Modified:
4 years, 8 months ago
Reviewers:
Ted C, Mathieu
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type and icon to credit card object in Java This patch adds the credit card type and issuer icon to the credit card object in Java. The issuer icon is shown to the user in PaymentRequest UI. The card types are strings as defined in "Basic Card Payment" W3C editor's draft: https://w3c.github.io/browser-payment-api/specs/basic-card-payment.html#method-id The card type is returned to the merchant website in PaymentRequest response object: https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentresponse-interface BUG=587995 Committed: https://crrev.com/297a4b7b0e8651b599f8f6e5ee7455b7ef792127 Cr-Commit-Position: refs/heads/master@{#388004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 4 chunks +19 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
please use gerrit instead
aurimas@, ptal.
4 years, 8 months ago (2016-04-18 19:28:24 UTC) #2
aurimas (slooooooooow)
I don't really do code reviews anymore. +tedchoc@
4 years, 8 months ago (2016-04-18 19:39:38 UTC) #4
Ted C
lgtm
4 years, 8 months ago (2016-04-18 19:51:57 UTC) #5
please use gerrit instead
mathp@, ptal chrome/browser/autofill/android/personal_data_manager_android.cc
4 years, 8 months ago (2016-04-18 20:05:42 UTC) #7
Mathieu
personal_data_manager_android lgtm
4 years, 8 months ago (2016-04-18 20:20:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902513002/1
4 years, 8 months ago (2016-04-18 20:33:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 20:38:48 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:40:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/297a4b7b0e8651b599f8f6e5ee7455b7ef792127
Cr-Commit-Position: refs/heads/master@{#388004}

Powered by Google App Engine
This is Rietveld 408576698