Chromium Code Reviews
Help | Chromium Project | Sign in
(5)

Issue 19025: Add support for UA spoofing, and spoof Safari's UA string when loading URLs... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by darin (slow to review)
Modified:
5 years, 10 months ago
Reviewers:
pentonyo, wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add support for UA spoofing, and spoof Safari's UA string when loading URLs from *.mail.live.com (to fix hotmail). BUG=4111 R=wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8764

Patch Set 1 #

Total comments: 15
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -38 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M net/url_request/url_request_context.h View 3 chunks +12 lines, -12 lines 5 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/url_request/url_request_inet_job.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M webkit/glue/plugins/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webframeloaderclient_impl.cc View 1 chunk +2 lines, -1 line 2 comments Download
M webkit/glue/webkit_glue.h View 1 chunk +1 line, -1 line 1 comment Download
M webkit/glue/webkit_glue.cc View 4 chunks +29 lines, -12 lines 6 comments Download
M webkit/tools/test_shell/test_shell_request_context.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 2 chunks +4 lines, -2 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 5 (0 generated)
darin (slow to review)
8 years, 2 months ago (2009-01-27 17:50:43 UTC) #1
wtc
LGTM. It shouldn't be hard to backport this CL to the release-stable branch. http://codereview.chromium.org/19025/diff/1/7 File ...
8 years, 2 months ago (2009-01-27 19:19:24 UTC) #2
darin (slow to review)
http://codereview.chromium.org/19025/diff/1/7 File net/url_request/url_request_context.h (right): http://codereview.chromium.org/19025/diff/1/7#newcode61 Line 61: // valid URL, then the default UA string ...
8 years, 2 months ago (2009-01-27 19:52:06 UTC) #3
darin (slow to review)
http://codereview.chromium.org/19025/diff/1/7 File net/url_request/url_request_context.h (right): http://codereview.chromium.org/19025/diff/1/7#newcode70 Line 70: virtual ~URLRequestContext() {} actually, nevermind. a private destructor ...
8 years, 2 months ago (2009-01-27 20:00:11 UTC) #4
Pentonyo_gmail.com
8 years, 1 month ago (2009-02-19 10:59:02 UTC) #5

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46