Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902493002: media: Fix gn deps on media/base/ targets (Closed)

Created:
4 years, 8 months ago by jrummell
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on media/base/ targets Add some needed dependencies. BUG=599578 Committed: https://crrev.com/6d87dca61001bcad07db8e996435731b0ffe65bd Cr-Commit-Position: refs/heads/master@{#388620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M media/base/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jrummell
PTAL. There are still a couple of dependencies in media/base/ that will require more work ...
4 years, 8 months ago (2016-04-18 18:54:48 UTC) #2
DaleCurtis
lgtm
4 years, 8 months ago (2016-04-20 19:24:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902493002/1
4 years, 8 months ago (2016-04-20 22:28:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:16:41 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:21 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6d87dca61001bcad07db8e996435731b0ffe65bd
Cr-Commit-Position: refs/heads/master@{#388620}

Powered by Google App Engine
This is Rietveld 408576698