Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1902433002: Do not create pending NavigationEntry when a transient one is present. (Closed)

Created:
4 years, 8 months ago by nasko
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Do not create pending NavigationEntry when a transient one is present. When an interestitial page is displayed, network requests from the existing RenderFrameHost are blocked. However, this still allows the renderer to send a DidStartProvisionalLoad IPC. This CL adds check whether when processing the IPC a transient entry is present and skips creating a pending entry. Otherwise the pending entry creation deletes the transient entry and leades to URL spoof. BUG=600046 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1881023003 Cr-Commit-Position: refs/heads/master@{#387545} (cherry picked from commit b2f82b84617fd2c1645a4a185f628f61f7741627) Committed: https://chromium.googlesource.com/chromium/src/+/5cb7488cf703179cea5af8ce5dff08fb4b9e2be4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -1 line) Patch
M chrome/browser/OWNERS View 2 chunks +10 lines, -0 lines 0 comments Download
A chrome/browser/chrome_navigation_browsertest.cc View 1 chunk +128 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/window_open_and_navigate.html View 1 chunk +13 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
nasko
4 years, 8 months ago (2016-04-18 17:04:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5cb7488cf703179cea5af8ce5dff08fb4b9e2be4 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698