Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190243003: [SyncFS] Move FROM_HEREs in SyncTaskManager to its client (Closed)

Created:
6 years, 9 months ago by tzik
Modified:
6 years, 9 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Move FROM_HEREs in SyncTaskManager to its client Move location marker to make logs meaningful. BUG=344769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255882

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -18 lines) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 9 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 11 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service.cc View 10 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_task_manager.h View 1 1 chunk +13 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/sync_task_manager.cc View 4 chunks +18 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/sync_task_manager_unittest.cc View 5 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tzik
PTL
6 years, 9 months ago (2014-03-07 06:56:45 UTC) #1
nhiroki
LGTM with style-nits https://codereview.chromium.org/190243003/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right): https://codereview.chromium.org/190243003/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode168 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:168: FROM_HERE, task.PassAs<SyncTask>(), SyncTaskManager::PRIORITY_HIGH, style-nit: can you ...
6 years, 9 months ago (2014-03-07 07:12:02 UTC) #2
tzik
https://codereview.chromium.org/190243003/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right): https://codereview.chromium.org/190243003/diff/1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode168 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:168: FROM_HERE, task.PassAs<SyncTask>(), SyncTaskManager::PRIORITY_HIGH, On 2014/03/07 07:12:03, nhiroki wrote: > ...
6 years, 9 months ago (2014-03-07 09:38:11 UTC) #3
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 9 months ago (2014-03-07 09:40:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/190243003/20001
6 years, 9 months ago (2014-03-07 09:42:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 14:46:14 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
6 years, 9 months ago (2014-03-07 14:46:16 UTC) #7
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 9 months ago (2014-03-10 04:36:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/190243003/40001
6 years, 9 months ago (2014-03-10 04:36:33 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 06:27:47 UTC) #10
Message was sent while issue was closed. 
Change committed as 255882

Powered by Google App Engine
This is Rietveld 408576698