Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1902423003: Make Dart_Initialize fail if a VM built as a JIT runtime gets a precompiled snapshot or vice versa. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, jsimmons1, Chinmay
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Dart_Initialize fail if a VM built as a JIT runtime gets a precompiled snapshot or vice versa. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/4bb6e9167c2f8635c5d90ab1bfd3a8d5153f0fb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M runtime/vm/dart.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 8 months ago (2016-04-20 22:29:17 UTC) #2
Cutch
lgtm
4 years, 8 months ago (2016-04-20 22:35:07 UTC) #3
rmacnak
4 years, 8 months ago (2016-04-20 23:01:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4bb6e9167c2f8635c5d90ab1bfd3a8d5153f0fb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698