Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Issue 1902423002: [Memory Health Plan] Set default --pageset-repeat value in the benchmark (Closed)

Created:
4 years, 8 months ago by perezju
Modified:
4 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Memory Health Plan] Set default --pageset-repeat value in the benchmark This sets the default value of --pageset-repeat, so it doesn't have to be known or specified by, e.g., bisect bots. The benchmark is split in two versions: - memory.memory_health_quick: pageset_repeat of 1, same as before. - memory.memory_health_plan: pageset_repeat of 5, disabled by default on bots (but can be run manually just fine). BUG=605079 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/882abee9ed85b4a7de93f6a7cdd1cdeb06336510 Cr-Commit-Position: refs/heads/master@{#388532}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 2 chunks +14 lines, -12 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
perezju
https://codereview.chromium.org/1902423002/diff/1/tools/perf/benchmarks/memory_infra.py File tools/perf/benchmarks/memory_infra.py (left): https://codereview.chromium.org/1902423002/diff/1/tools/perf/benchmarks/memory_infra.py#oldcode70 tools/perf/benchmarks/memory_infra.py:70: and any(value.name.startswith(p) for p in cls._PREFIX_WHITELIST)) Took the chance ...
4 years, 8 months ago (2016-04-20 15:17:13 UTC) #3
sullivan
lgtm This lgtm but please also wait for either Ethan or Ned to take a ...
4 years, 8 months ago (2016-04-20 15:18:36 UTC) #4
nednguyen
lgtm
4 years, 8 months ago (2016-04-20 15:47:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902423002/1
4 years, 8 months ago (2016-04-20 15:47:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 17:54:13 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/882abee9ed85b4a7de93f6a7cdd1cdeb06336510
Cr-Commit-Position: refs/heads/master@{#388532}

Powered by Google App Engine
This is Rietveld 408576698