Issue 1902403005: Don't use AnalysisContext.exists() in VerifyUnitTask.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1902403005: Don't use AnalysisContext.exists() in VerifyUnitTask. (Closed)

Created:
4 years, 8 months ago by scheglov

Modified:
4 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use AnalysisContext.exists() in VerifyUnitTask. Use REFERENCED_SOURCES and MODIFICATION_TIME instead. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8a7b4ea225f341a0d2fc989b21409a78dacfa01e

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
M	pkg/analyzer/doc/tasks.html	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View		5 chunks	+19 lines, -1 line	0 comments	Download
M	pkg/analyzer/tool/task_dependency_graph/tasks.dot	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 8 months ago (2016-04-20 21:02:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8a7b4ea225f341a0d2fc989b21409a78dacfa01e (presubmit successful).