Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1902403003: Change the ellpisis (...) to Options as per UI review feedback (Closed)

Created:
4 years, 8 months ago by Miguel Garcia
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ... for Options as per UI review feedback BUG=571056 Committed: https://crrev.com/15371b2a32a38be230048d24fa61abaf94309a5a Cr-Commit-Position: refs/heads/master@{#388511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Miguel Garcia
As per UX review feedback they suggested changing the ... to Options. I actually don't ...
4 years, 8 months ago (2016-04-20 15:09:24 UTC) #2
Robert Sesek
lgtm
4 years, 8 months ago (2016-04-20 15:18:38 UTC) #3
Miguel Garcia
+Peter for owners
4 years, 8 months ago (2016-04-20 15:21:21 UTC) #5
Peter Beverloo
lgtm
4 years, 8 months ago (2016-04-20 15:32:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902403003/1
4 years, 8 months ago (2016-04-20 15:33:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 16:14:45 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15371b2a32a38be230048d24fa61abaf94309a5a
Cr-Commit-Position: refs/heads/master@{#388511}

Powered by Google App Engine
This is Rietveld 408576698