Add support for ios_web_shell xctest for devices.

Add support for ios_web_shell xctest for devices.

This CL depends on https://codereview.chromium.org/1907523002/.

BUG=

Committed: https://crrev.com/732d398bc4cc7aba0bd7f763940fbed2819f2209
Cr-Commit-Position: refs/heads/master@{#389765}

[justincohen, 2016-04-20 21:10:48]

justincohen@chromium.org changed reviewers:
+ baxley@chromium.org, rohitrao@chromium.org, sdefresne@chromium.org

[justincohen, 2016-04-20 21:10:49]

ptal

https://codereview.chromium.org/1902373003/diff/1/ios/web/ios_web_shell_tests...
File ios/web/ios_web_shell_tests.gyp (right):

https://codereview.chromium.org/1902373003/diff/1/ios/web/ios_web_shell_tests...
ios/web/ios_web_shell_tests.gyp:75: 'configurations': {
Is there an easier way to do this?  I need to disable stripping and codesign for
this target, but this seems to be the only way to override it.

https://codereview.chromium.org/1902373003/diff/1/ios/web/ios_web_shell_tests...
ios/web/ios_web_shell_tests.gyp:102: '<(PRODUCT_DIR)/<(_target_name).app'
Is there a better way to do this as well?

[sdefresne, 2016-04-21 16:27:09]

https://codereview.chromium.org/1902373003/diff/1/ios/third_party/earl_grey/e...
File ios/third_party/earl_grey/earl_grey.gyp (right):

https://codereview.chromium.org/1902373003/diff/1/ios/third_party/earl_grey/e...
ios/third_party/earl_grey/earl_grey.gyp:274: 'INFOPLIST_FILE':
'src/EarlGrey-Info.plist',
File missing?

https://codereview.chromium.org/1902373003/diff/1/ios/third_party/ochamcrest/...
File ios/third_party/ochamcrest/ochamcrest.gyp (right):

https://codereview.chromium.org/1902373003/diff/1/ios/third_party/ochamcrest/...
ios/third_party/ochamcrest/ochamcrest.gyp:232: 'INFOPLIST_FILE':
'src/Source/OCHamcrest-Info.plist',
File missing?

[justincohen, 2016-04-24 20:26:45]

ptal

https://codereview.chromium.org/1902373003/diff/1/ios/third_party/earl_grey/e...
File ios/third_party/earl_grey/earl_grey.gyp (right):

https://codereview.chromium.org/1902373003/diff/1/ios/third_party/earl_grey/e...
ios/third_party/earl_grey/earl_grey.gyp:274: 'INFOPLIST_FILE':
'src/EarlGrey-Info.plist',
On 2016/04/21 16:27:09, sdefresne wrote:
> File missing?

No, this file lives in eg third party.

https://codereview.chromium.org/1902373003/diff/1/ios/third_party/ochamcrest/...
File ios/third_party/ochamcrest/ochamcrest.gyp (right):

https://codereview.chromium.org/1902373003/diff/1/ios/third_party/ochamcrest/...
ios/third_party/ochamcrest/ochamcrest.gyp:232: 'INFOPLIST_FILE':
'src/Source/OCHamcrest-Info.plist',
On 2016/04/21 16:27:09, sdefresne wrote:
> File missing?

No, this file lives in OC third party.

https://codereview.chromium.org/1902373003/diff/1/ios/web/ios_web_shell_tests...
File ios/web/ios_web_shell_tests.gyp (right):

https://codereview.chromium.org/1902373003/diff/1/ios/web/ios_web_shell_tests...
ios/web/ios_web_shell_tests.gyp:75: 'configurations': {
On 2016/04/20 21:10:49, justincohen wrote:
> Is there an easier way to do this?  I need to disable stripping and codesign
for
> this target, but this seems to be the only way to override it.

Ack, this is now gone.

https://codereview.chromium.org/1902373003/diff/1/ios/web/ios_web_shell_tests...
ios/web/ios_web_shell_tests.gyp:102: '<(PRODUCT_DIR)/<(_target_name).app'
On 2016/04/20 21:10:49, justincohen wrote:
> Is there a better way to do this as well?

This can be done simpler in GN, leaving for now in GYP

[justincohen, 2016-04-26 02:59:09]

Updated this Cl to embed eg tests inside the TEST_HOST, similar to this
downstream equivalent: https://chromereviews.googleplex.com/411197013/


PTAL!

[sdefresne, 2016-04-26 07:09:52]

lgtm

[rohitrao (ping after 24h), 2016-04-26 11:40:58]

lgtm

https://codereview.chromium.org/1902373003/diff/40001/ios/web/ios_web_shell_t...
File ios/web/ios_web_shell_tests.gyp (right):

https://codereview.chromium.org/1902373003/diff/40001/ios/web/ios_web_shell_t...
ios/web/ios_web_shell_tests.gyp:60: 'public/test/http_server_util.h',
We should move these files (except for _egtest.mm) into an
ios_web_shell_test_support target, but that can happen outside of this CL.

https://codereview.chromium.org/1902373003/diff/40001/ios/web/shell/test/Info...
File ios/web/shell/test/Info.plist (right):

https://codereview.chromium.org/1902373003/diff/40001/ios/web/shell/test/Info...
ios/web/shell/test/Info.plist:1: <?xml version="1.0" encoding="UTF-8"?>
Should we name this Module-Info.plist?

https://codereview.chromium.org/1902373003/diff/40001/ios/web/shell/test/shel...
File ios/web/shell/test/shell_test.mm (right):

https://codereview.chromium.org/1902373003/diff/40001/ios/web/shell/test/shel...
ios/web/shell/test/shell_test.mm:5: #import <UIKit/UIKit.h>
#import <Foundation/Foundation.h>

Because that's all we need, and it matches what's in the gyp file.

[justincohen, 2016-04-26 12:27:55]

https://codereview.chromium.org/1902373003/diff/40001/ios/web/ios_web_shell_t...
File ios/web/ios_web_shell_tests.gyp (right):

https://codereview.chromium.org/1902373003/diff/40001/ios/web/ios_web_shell_t...
ios/web/ios_web_shell_tests.gyp:60: 'public/test/http_server_util.h',
On 2016/04/26 11:40:58, rohitrao wrote:
> We should move these files (except for _egtest.mm) into an
> ios_web_shell_test_support target, but that can happen outside of this CL.

+ baxley, for follow up.

https://codereview.chromium.org/1902373003/diff/40001/ios/web/shell/test/Info...
File ios/web/shell/test/Info.plist (right):

https://codereview.chromium.org/1902373003/diff/40001/ios/web/shell/test/Info...
ios/web/shell/test/Info.plist:1: <?xml version="1.0" encoding="UTF-8"?>
On 2016/04/26 11:40:58, rohitrao wrote:
> Should we name this Module-Info.plist?

Done.

https://codereview.chromium.org/1902373003/diff/40001/ios/web/shell/test/shel...
File ios/web/shell/test/shell_test.mm (right):

https://codereview.chromium.org/1902373003/diff/40001/ios/web/shell/test/shel...
ios/web/shell/test/shell_test.mm:5: #import <UIKit/UIKit.h>
On 2016/04/26 11:40:58, rohitrao wrote:
> #import <Foundation/Foundation.h>
> 
> Because that's all we need, and it matches what's in the gyp file.

Done.

[justincohen, 2016-04-26 12:27:58]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-04-26 12:28:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902373003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902373003/40001

[justincohen, 2016-04-26 12:30:20]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-04-26 12:30:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/1902373003/#ps60001
(title: "Info.plist -> Module-Info.plist")

[commit-bot: I haz the power, 2016-04-26 12:30:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902373003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902373003/60001

[commit-bot: I haz the power, 2016-04-26 13:10:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-26 13:11:58]

Description was changed from

==========
Add support for ios_web_shell xctest for devices.

This CL depends on https://codereview.chromium.org/1907523002/.

BUG=
==========

to

==========
Add support for ios_web_shell xctest for devices.

This CL depends on https://codereview.chromium.org/1907523002/.

BUG=

Committed: https://crrev.com/732d398bc4cc7aba0bd7f763940fbed2819f2209
Cr-Commit-Position: refs/heads/master@{#389765}
==========

[commit-bot: I haz the power, 2016-04-26 13:11:59]

Patchset 4 (id:??) landed as
https://crrev.com/732d398bc4cc7aba0bd7f763940fbed2819f2209
Cr-Commit-Position: refs/heads/master@{#389765}

[baxley, 2016-04-26 14:31:17]

On 2016/04/26 12:27:55, justincohen wrote:
>
https://codereview.chromium.org/1902373003/diff/40001/ios/web/ios_web_shell_t...
> File ios/web/ios_web_shell_tests.gyp (right):
> 
>
https://codereview.chromium.org/1902373003/diff/40001/ios/web/ios_web_shell_t...
> ios/web/ios_web_shell_tests.gyp:60: 'public/test/http_server_util.h',
> On 2016/04/26 11:40:58, rohitrao wrote:
> > We should move these files (except for _egtest.mm) into an
> > ios_web_shell_test_support target, but that can happen outside of this CL.
> 
> + baxley, for follow up.
Agreed. For now we were just iterating to see how the utilities would shape up
before we start grouping them. I'll take care of this change.