Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1902373002: [builtins] Introduce a proper BUILTIN frame type. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce a proper BUILTIN frame type. This adds a new BUILTIN frame type, which supports variable number of arguments for builtins implemented in hand-written native code (we will extend this mechanism to TurboFan builtins at some point). Convert the Math.max and Math.min builtins to construct a BUILTIN frame if required. This does not yet work for C++ builtins, but that'll be the next step. R=jarin@chromium.org BUG=v8:4815 LOG=n

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -83 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +24 lines, -19 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 4 chunks +26 lines, -19 lines 0 comments Download
M src/frames.h View 5 chunks +34 lines, -3 lines 1 comment Download
M src/frames.cc View 4 chunks +18 lines, -9 lines 1 comment Download
M src/frames-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 4 chunks +10 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 4 chunks +22 lines, -14 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 4 chunks +24 lines, -16 lines 0 comments Download
M src/x64/builtins-x64.cc View 4 chunks +10 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-4815.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-20 10:37:14 UTC) #1
Jarin
4 years, 8 months ago (2016-04-20 11:47:57 UTC) #2
lgtm.

https://codereview.chromium.org/1902373002/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1902373002/diff/1/src/frames.cc#newcode459
src/frames.cc:459: return OPTIMIZED;
What would go wrong if you also optimized functions returned BUILTIN type?
(Pointer maps?)

https://codereview.chromium.org/1902373002/diff/1/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/1902373002/diff/1/src/frames.h#newcode957
src/frames.h:957: // Builtin frames are built for builtins with JavaScript
linkage, like
Nit: like -> such as

Powered by Google App Engine
This is Rietveld 408576698