Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1902353002: S390: Change calling convention of CallApiGetterStub to accept the AccessorInfo (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Change calling convention of CallApiGetterStub to accept the AccessorInfo Port d2b0a4b727f77f97960c7fa71da3431591dc959f Original commit message: MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>; R= verwaest@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/aef33eda0905a0e3d2724f963a8b567f14df59c2 Cr-Commit-Position: refs/heads/master@{#35658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -59 lines) Patch
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 2 chunks +34 lines, -9 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-20 04:02:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902353002/1
4 years, 8 months ago (2016-04-20 04:02:42 UTC) #3
JoranSiu
On 2016/04/20 04:02:42, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 8 months ago (2016-04-20 04:15:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 04:23:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902353002/1
4 years, 8 months ago (2016-04-20 13:23:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 13:25:59 UTC) #9
nodir1
4 years, 8 months ago (2016-04-22 18:44:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aef33eda0905a0e3d2724f963a8b567f14df59c2
Cr-Commit-Position: refs/heads/master@{#35658}

Powered by Google App Engine
This is Rietveld 408576698