Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1902333002: Fix DM blaze build (PNG output is now dependent on picture_utils) (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
Reviewers:
dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902333002/1
4 years, 8 months ago (2016-04-20 02:20:50 UTC) #3
Brian Osman
Realized (too late) that the blaze build file is in the Skia repository. So yeah ...
4 years, 8 months ago (2016-04-20 02:21:59 UTC) #5
Brian Osman
Oops, sent to the wrong Ben.
4 years, 8 months ago (2016-04-20 02:24:46 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 02:30:41 UTC) #11
mtklein
lgtm
4 years, 8 months ago (2016-04-20 02:40:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902333002/1
4 years, 8 months ago (2016-04-20 02:41:00 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 02:41:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6d3119c9fc09ff1cf94965089d0873941097c1bc

Powered by Google App Engine
This is Rietveld 408576698