Reland of Replace libusb in the Linux/Chrome OS USB I/O path.

Reland of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1 of https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3 id:60001 of https://codereview.chromium.org/1877503003/ )
>
> Reason for revert:
> broke u2f see crbug.com/603962
>
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562, 601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
>
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562, 601627, 603962
>
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562, 601627, 603962
Committed: https://crrev.com/2f3b6285b45d43141dfc72131dd81702e4342f85
Cr-Commit-Position: refs/heads/master@{#388402}

[Reilly Grant (use Gerrit), 2016-04-20 00:26:53]

Created Reland of place libusb in the Linux/Chrome OS USB I/O path.

[Reilly Grant (use Gerrit), 2016-04-20 00:27:23]

reillyg@chromium.org changed reviewers:
- wfh@chromium.org

[Reilly Grant (use Gerrit), 2016-04-20 00:36:56]

Please take a look. I've fixed the issue that led to this patch being reverted.
On the non-Linux open path a failure would not result in the callback being
called with nullptr and so enumeration and connections would simply hang.

[Will Harris, 2016-04-20 00:39:58]

wfh@chromium.org changed reviewers:
+ wfh@chromium.org

[Will Harris, 2016-04-20 00:39:59]

https://codereview.chromium.org/1902313002/diff/180001/device/usb/usb_device_...
File device/usb/usb_device_impl.cc (right):

https://codereview.chromium.org/1902313002/diff/180001/device/usb/usb_device_...
device/usb/usb_device_impl.cc:340: task_runner_->PostTask(FROM_HERE,
base::Bind(callback, nullptr));
does this change need a review from anyone (not me, I'm not familiar with the
code).

[Will Harris, 2016-04-20 00:40:52]

Oh nvm I thought you were committing this as a revert CL with TBR. email
confused me :)

[Will Harris, 2016-04-20 00:41:00]

Description was changed from

==========
Reland of place libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1 of
https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3
id:60001 of https://codereview.chromium.org/1877503003/ )
> 
> Reason for revert:
> broke u2f see crbug.com/603962
> 
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562,601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
> 
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562,601627,603962
> 
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

TBR=juncai@chromium.org,wfh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562,601627,603962
==========

to

==========
Reland of place libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1 of
https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3
id:60001 of https://codereview.chromium.org/1877503003/ )
> 
> Reason for revert:
> broke u2f see crbug.com/603962
> 
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562,601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
> 
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562,601627,603962
> 
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

TBR=juncai@chromium.org,wfh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562,601627,603962
==========

[Will Harris, 2016-04-20 00:41:00]

wfh@chromium.org changed reviewers:
- wfh@chromium.org

[Reilly Grant (use Gerrit), 2016-04-20 00:42:19]

Description was changed from

==========
Reland of place libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1 of
https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3
id:60001 of https://codereview.chromium.org/1877503003/ )
> 
> Reason for revert:
> broke u2f see crbug.com/603962
> 
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562,601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
> 
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562,601627,603962
> 
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

TBR=juncai@chromium.org,wfh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562,601627,603962
==========

to

==========
Reland of place libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1 of
https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3
id:60001 of https://codereview.chromium.org/1877503003/ )
> 
> Reason for revert:
> broke u2f see crbug.com/603962
> 
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562,601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
> 
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562,601627,603962
> 
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562,601627,603962
==========

[Reilly Grant (use Gerrit), 2016-04-20 00:42:36]

On 2016/04/20 at 00:40:52, wfh wrote:
> Oh nvm I thought you were committing this as a revert CL with TBR. email
confused me :)

Removed the TBR, sorry for the confusion. I would like juncai@ to review.

[Will Harris, 2016-04-20 00:44:20]

p.s. thanks for fixing this!

[Reilly Grant (use Gerrit), 2016-04-20 00:45:38]

Description was changed from

==========
Reland of place libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1 of
https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3
id:60001 of https://codereview.chromium.org/1877503003/ )
> 
> Reason for revert:
> broke u2f see crbug.com/603962
> 
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562,601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
> 
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562,601627,603962
> 
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562,601627,603962
==========

to

==========
Reland of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1
of https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3
id:60001 of https://codereview.chromium.org/1877503003/ )
> 
> Reason for revert:
> broke u2f see crbug.com/603962
> 
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562,601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
> 
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562,601627,603962
> 
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562,601627,603962
==========

[juncai, 2016-04-20 00:46:02]

LGTM.

[Reilly Grant (use Gerrit), 2016-04-20 00:50:16]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-20 00:50:16]

The patchset sent to the CQ was uploaded after l-g-t-m from juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/1902313002/#ps200001
(title: "Rebase over scoped_ptr -> unique_ptr change.")

[commit-bot: I haz the power, 2016-04-20 00:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902313002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902313002/200001

[commit-bot: I haz the power, 2016-04-20 01:47:37]

Committed patchset #3 (id:200001)

[commit-bot: I haz the power, 2016-04-22 19:19:53]

Description was changed from

==========
Reland of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1
of https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3
id:60001 of https://codereview.chromium.org/1877503003/ )
> 
> Reason for revert:
> broke u2f see crbug.com/603962
> 
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562,601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
> 
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562,601627,603962
> 
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562,601627,603962
==========

to

==========
Reland of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #1 id:1
of https://codereview.chromium.org/1897483003/ )

Reason for revert:
Fixed Windows/OS X issue.

Original issue's description:
> Revert of Replace libusb in the Linux/Chrome OS USB I/O path. (patchset #3
id:60001 of https://codereview.chromium.org/1877503003/ )
>
> Reason for revert:
> broke u2f see crbug.com/603962
>
> Original issue's description:
> > Replace libusb in the Linux/Chrome OS USB I/O path.
> >
> > As a first step in adding support for connecting to USB devices on
> > Android this patch replaces the libusb-based implementation of
> > UsbDeviceHandle used on Linux and Chrome OS with one written directly to
> > the Linux usbdevfs ioctl interface.
> >
> > BUG=422562,601627
> >
> > Committed: https://crrev.com/fed1de7faf5d91a3282d461fd1c0657f8fe3a533
> > Cr-Commit-Position: refs/heads/master@{#387315}
>
> TBR=juncai@chromium.org,reillyg@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=422562,601627,603962
>
> Committed: https://crrev.com/4ee09b3e7eab98835bc1a47c55f3b3080c2f5fd3
> Cr-Commit-Position: refs/heads/master@{#387704}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=422562,601627,603962

Committed: https://crrev.com/2f3b6285b45d43141dfc72131dd81702e4342f85
Cr-Commit-Position: refs/heads/master@{#388402}
==========

[commit-bot: I haz the power, 2016-04-22 19:19:54]

Patchset 3 (id:??) landed as
https://crrev.com/2f3b6285b45d43141dfc72131dd81702e4342f85
Cr-Commit-Position: refs/heads/master@{#388402}