Add MD Feedback switch.

Add MD Feedback switch.

This change adds the switch for MD feedback. The feature can be enabled by passing in the --enable-md-feedback or enabling MD feedback from chrome://flags.

BUG=604586
Committed: https://crrev.com/739000955e27e0581649d3c64d32fcfd33a0941d
Cr-Commit-Position: refs/heads/master@{#389792}

[apacible, 2016-04-19 21:57:28]

Patchset #1 (id:1) has been deleted

[apacible, 2016-04-19 22:45:17]

Description was changed from

==========
feature switch

BUG=
==========

to

==========
[Not For Review] Add MD Feedback switch.
==========

[apacible, 2016-04-19 22:45:25]

Patchset #1 (id:20001) has been deleted

[apacible, 2016-04-19 22:51:11]

Patchset #1 (id:40001) has been deleted

[apacible, 2016-04-21 00:41:33]

Patchset #2 (id:80001) has been deleted

[apacible, 2016-04-25 20:34:21]

Patchset #1 (id:60001) has been deleted

[apacible, 2016-04-25 20:34:37]

Patchset #1 (id:100001) has been deleted

[apacible, 2016-04-25 20:35:42]

Description was changed from

==========
[Not For Review] Add MD Feedback switch.
==========

to

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. Passing in the --enable-md-feedback
or enabling MD feedback from chrome://flags will enable MD feedback.
==========

[apacible, 2016-04-25 20:41:18]

Patchset #1 (id:120001) has been deleted

[apacible, 2016-04-25 20:42:00]

Description was changed from

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. Passing in the --enable-md-feedback
or enabling MD feedback from chrome://flags will enable MD feedback.
==========

to

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. The feature can be enabled by
passing in the --enable-md-feedback or enabling MD feedback from chrome://flags.
==========

[apacible, 2016-04-25 20:43:47]

apacible@chromium.org changed reviewers:
+ mfoltz@chromium.org

[apacible, 2016-04-25 20:45:33]

PTAL, thanks!

Manually tested with --enable-md-feedback and chrome://flags with logging.

[apacible, 2016-04-25 20:45:53]

Description was changed from

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. The feature can be enabled by
passing in the --enable-md-feedback or enabling MD feedback from chrome://flags.
==========

to

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. The feature can be enabled by
passing in the --enable-md-feedback or enabling MD feedback from chrome://flags.

BUG=604586
==========

[mark a. foltz, 2016-04-25 23:00:29]

lgtm but I believe you need to update histograms.xml with the new flag

https://codereview.chromium.org/1902293002/diff/140001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1902293002/diff/140001/chrome/app/generated_r...
chrome/app/generated_resources.grd:4989: +          If enabled, selecting
"Report an issue..." from the overflow menu will load the Material Design
feedback UI.
Nit: I believe there are other places you can file feedback, especially on
ChromeOS.

Maybe just "If enabled, reporting an issue will load..."

[apacible, 2016-04-26 00:43:43]

apacible@chromium.org changed reviewers:
+ isherman@chromium.org

[apacible, 2016-04-26 00:45:18]

+isherman for histograms.xml

PTAL, thanks!

https://codereview.chromium.org/1902293002/diff/140001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1902293002/diff/140001/chrome/app/generated_r...
chrome/app/generated_resources.grd:4989: +          If enabled, selecting
"Report an issue..." from the overflow menu will load the Material Design
feedback UI.
On 2016/04/25 23:00:29, mark a. foltz wrote:
> Nit: I believe there are other places you can file feedback, especially on
> ChromeOS.
> 
> Maybe just "If enabled, reporting an issue will load..."

Done.

[Ilya Sherman, 2016-04-26 15:15:33]

histograms.xml lgtm

[apacible, 2016-04-26 15:30:41]

The CQ bit was checked by apacible@chromium.org

[apacible, 2016-04-26 15:30:41]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/1902293002/#ps160001
(title: "Changes per mfoltz@'s comments.")

[commit-bot: I haz the power, 2016-04-26 15:31:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1902293002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1902293002/160001

[commit-bot: I haz the power, 2016-04-26 15:41:09]

Description was changed from

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. The feature can be enabled by
passing in the --enable-md-feedback or enabling MD feedback from chrome://flags.

BUG=604586
==========

to

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. The feature can be enabled by
passing in the --enable-md-feedback or enabling MD feedback from chrome://flags.

BUG=604586
==========

[commit-bot: I haz the power, 2016-04-26 15:41:10]

Committed patchset #2 (id:160001)

[commit-bot: I haz the power, 2016-04-26 15:42:22]

Description was changed from

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. The feature can be enabled by
passing in the --enable-md-feedback or enabling MD feedback from chrome://flags.

BUG=604586
==========

to

==========
Add MD Feedback switch.

This change adds the switch for MD feedback. The feature can be enabled by
passing in the --enable-md-feedback or enabling MD feedback from chrome://flags.

BUG=604586

Committed: https://crrev.com/739000955e27e0581649d3c64d32fcfd33a0941d
Cr-Commit-Position: refs/heads/master@{#389792}
==========

[commit-bot: I haz the power, 2016-04-26 15:42:23]

Patchset 2 (id:??) landed as
https://crrev.com/739000955e27e0581649d3c64d32fcfd33a0941d
Cr-Commit-Position: refs/heads/master@{#389792}