Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902263006: Prevent module system from loading arbitrary modules (Closed)

Created:
4 years, 8 months ago by robwu
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent module system from loading arbitrary modules BUG=603725 Committed: https://crrev.com/15574e83265d53f65ce653de0db34c738bdb89f9 Cr-Commit-Position: refs/heads/master@{#388526}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M extensions/renderer/resources/binding.js View 1 chunk +13 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
robwu
4 years, 8 months ago (2016-04-20 10:48:10 UTC) #3
Devlin
lgtm https://codereview.chromium.org/1902263006/diff/1/extensions/renderer/resources/binding.js File extensions/renderer/resources/binding.js (right): https://codereview.chromium.org/1902263006/diff/1/extensions/renderer/resources/binding.js#newcode169 extensions/renderer/resources/binding.js:169: // This list contains all types that has ...
4 years, 8 months ago (2016-04-20 14:12:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902263006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902263006/1
4 years, 8 months ago (2016-04-20 16:36:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 17:27:53 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:37 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/15574e83265d53f65ce653de0db34c738bdb89f9
Cr-Commit-Position: refs/heads/master@{#388526}

Powered by Google App Engine
This is Rietveld 408576698