Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1902263003: Disable -Wundefined-var-template on the clang tot bots. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable -Wundefined-var-template on the clang tot bots. It's a new warning upstream and it fires in several places in Chromium. Suppress this for now to get the clang tot bots back green. BUG=604888 TBR=hans@chromium.org Committed: https://crrev.com/d4e7c5c697e2d59d897a7bbedc77a33d798df85b Cr-Commit-Position: refs/heads/master@{#388364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
4 years, 8 months ago (2016-04-19 21:15:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902263003/1
4 years, 8 months ago (2016-04-19 21:16:33 UTC) #3
hans
lgtm
4 years, 8 months ago (2016-04-19 21:29:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 23:52:17 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:18:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4e7c5c697e2d59d897a7bbedc77a33d798df85b
Cr-Commit-Position: refs/heads/master@{#388364}

Powered by Google App Engine
This is Rietveld 408576698