Support fixed prefixes and suffixes when extracting terms from search template URLs.

components/search_engines/template_url_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 1174 matching lines @@
       result);
 
   EXPECT_TRUE(url.ExtractSearchTermsFromURL(
       GURL("http://windows-1251.ru/path/%E1%F3%EA%E2%FB%20%C0%20%E8%20A"),
       search_terms_data_, &result));
   EXPECT_EQ(
       base::WideToUTF16(L"\x0431\x0443\x043A\x0432\x044B \x0410 \x0438 A"),
       result);
 }
 
+// Checks that the ExtractSearchTermsFromURL function strips constant
+// prefix/suffix strings from the search terms param.
+TEST_F(TemplateURLTest, ExtractSearchTermsWithPrefixAndSuffix) {
+  TemplateURLData data;
+  data.alternate_urls.push_back("http://www.example.com/?q=chromium-{searchTerms}@chromium.org");
+  data.alternate_urls.push_back("http://www.example.com/chromium-{searchTerms}@chromium.org/info");
+  TemplateURL url(data);
+  base::string16 result;
+
+  EXPECT_TRUE(url.ExtractSearchTermsFromURL(
+      GURL("http://www.example.com/?q=chromium-dev@chromium.org"),
+      search_terms_data_, &result));
+  EXPECT_EQ(ASCIIToUTF16("dev"), result);
+
+  EXPECT_TRUE(url.ExtractSearchTermsFromURL(
+      GURL("http://www.example.com/chromium-dev@chromium.org/info"),
+      search_terms_data_, &result));
+  EXPECT_EQ(ASCIIToUTF16("dev"), result);
+
+  // To be safe, still succeed if they're missing. This is no worse than the
+  // previous behavior.
+  EXPECT_TRUE(url.ExtractSearchTermsFromURL(
+      GURL("http://www.example.com/?q=invalid"), search_terms_data_, &result));
+  EXPECT_EQ(ASCIIToUTF16("invalid"), result);

[Peter Kasting, 2016/04/21 19:48:57]

Hmm.  I don't think we should allow "foo.com/?q=xyz-{searchTerms}" to match
against "foo.com/?q=abc".  That's too aggressive; it's not clear why the user
would want to allow this.

If the pattern URL has a prefix/suffix, I think we shouldn't match unless
they're present in the input URL.

[jbroman, 2016/04/21 21:01:42]

My reasoning was that they were accepted before this CL, so it seemed to make
the change have less impact. I've changed it to require the prefix and suffix to
exist, and adjusted this test case accordingly.

+}
+
 TEST_F(TemplateURLTest, HasSearchTermsReplacementKey) {
   TemplateURLData data;
   data.SetURL("http://google.com/?q={searchTerms}");
   data.instant_url = "http://google.com/instant#q={searchTerms}";
   data.alternate_urls.push_back("http://google.com/alt/#q={searchTerms}");
   data.alternate_urls.push_back(
       "http://google.com/alt/?ext=foo&q={searchTerms}#ref=bar");
   data.search_terms_replacement_key = "espv";
   TemplateURL url(data);
 
@@ skipping 573 matching lines @@
       GURL("https://www.foo.org/search?q=Y+Z"),
       search_terms_data_, &search_terms));
   EXPECT_EQ(base::ASCIIToUTF16("Y Z"), search_terms);
   EXPECT_TRUE(url.ExtractSearchTermsFromURL(
       GURL("https://www.foo.org/s#q=123"),
       search_terms_data_, &search_terms));
   EXPECT_EQ(base::ASCIIToUTF16("123"), search_terms);
 
   search_terms_data_.set_google_base_url("http://www.google.com/");
 }