Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: components/search_engines/template_url.h

Issue 1902263002: Support fixed prefixes and suffixes when extracting terms from search template URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_ 5 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_
6 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_ 6 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 mutable Replacements replacements_; 460 mutable Replacements replacements_;
461 461
462 // Host, port, path, key and location of the search term. These are only set 462 // Host, port, path, key and location of the search term. These are only set
463 // if the url contains one search term. 463 // if the url contains one search term.
464 mutable std::string host_; 464 mutable std::string host_;
465 mutable std::string port_; 465 mutable std::string port_;
466 mutable std::string path_; 466 mutable std::string path_;
467 mutable std::string search_term_key_; 467 mutable std::string search_term_key_;
468 mutable size_t search_term_position_in_path_; 468 mutable size_t search_term_position_in_path_;
469 mutable url::Parsed::ComponentType search_term_key_location_; 469 mutable url::Parsed::ComponentType search_term_key_location_;
470 mutable std::string search_term_value_prefix_;
471 mutable std::string search_term_value_suffix_;
Peter Kasting 2016/04/21 19:48:57 I wonder if it would be any simpler/clearer to use
jbroman 2016/04/21 21:01:42 I don't understand; IIUC url::Component is a (begi
Peter Kasting 2016/04/21 22:29:46 Yeah, sorry, I was misconceiving how these were be
470 472
471 mutable PostParams post_params_; 473 mutable PostParams post_params_;
472 474
473 // Whether the contained URL is a pre-populated URL. 475 // Whether the contained URL is a pre-populated URL.
474 bool prepopulated_; 476 bool prepopulated_;
475 }; 477 };
476 478
477 479
478 // TemplateURL ---------------------------------------------------------------- 480 // TemplateURL ----------------------------------------------------------------
479 481
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 TemplateURLRef new_tab_url_ref_; 747 TemplateURLRef new_tab_url_ref_;
746 TemplateURLRef contextual_search_url_ref_; 748 TemplateURLRef contextual_search_url_ref_;
747 scoped_ptr<AssociatedExtensionInfo> extension_info_; 749 scoped_ptr<AssociatedExtensionInfo> extension_info_;
748 750
749 // TODO(sky): Add date last parsed OSD file. 751 // TODO(sky): Add date last parsed OSD file.
750 752
751 DISALLOW_COPY_AND_ASSIGN(TemplateURL); 753 DISALLOW_COPY_AND_ASSIGN(TemplateURL);
752 }; 754 };
753 755
754 #endif // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_ 756 #endif // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_H_
OLDNEW
« no previous file with comments | « no previous file | components/search_engines/template_url.cc » ('j') | components/search_engines/template_url.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698