Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Issue 1902253003: add gm to exercise rotated imagefiltesr w/ and w/o antialiasing (Closed)

Created:
4 years, 8 months ago by reed1
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M gm/imagefilterstransformed.cpp View 1 chunk +41 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
reed1
4 years, 8 months ago (2016-04-19 20:08:49 UTC) #3
Stephen White
Looks fine, but note that we already have gm/imagefilterstransformed.cpp. Could you add AA to that ...
4 years, 8 months ago (2016-04-19 20:29:19 UTC) #4
Stephen White
What I mean is, could you just add an "AA" for-loop to the existing GM ...
4 years, 8 months ago (2016-04-19 20:32:48 UTC) #5
reed1
I found the current one hard to see the edge differences (due to size and ...
4 years, 8 months ago (2016-04-19 20:42:45 UTC) #6
Stephen White
On 2016/04/19 20:42:45, reed1 wrote: > I found the current one hard to see the ...
4 years, 8 months ago (2016-04-19 20:44:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902253003/1
4 years, 8 months ago (2016-04-19 20:48:38 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 21:02:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/51dece33e8b9e3914b0b90086f4b2e97c17333dd

Powered by Google App Engine
This is Rietveld 408576698