Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1902163003: PPC: Remove all non-function-name uses of CONST_LEGACY (Closed)

Created:
4 years, 8 months ago by JaideepBajwa
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Remove all non-function-name uses of CONST_LEGACY Port 59546149c600a2262339e82b6d24e407a71e7a98 Original commit message: Now that all 'const' declarations are of the ES2015 variety, the only use of CONST_LEGACY is for function name bindings in sloppy mode named function expressions. This patch aims to delete all code meant to handle other cases, which mostly had to do with hole initialization/hole checks. Since function name bindings are initialized at entry to a function, it's impossible to ever observe one in an uninitialized state. To simplify the patch further, it removes the `IMPORT` VariableMode, as it's not likely to be needed (IMPORT is identical to CONST for the purpose of VariableMode). R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/f8844a6ee1fa15ee0f12ef34221a79fd3594966b Cr-Commit-Position: refs/heads/master@{#35635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -35 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 5 chunks +6 lines, -35 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 8 months ago (2016-04-19 18:49:58 UTC) #1
MTBrandyberry
lgtm
4 years, 8 months ago (2016-04-19 18:52:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902163003/1
4 years, 8 months ago (2016-04-19 19:14:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 19:33:29 UTC) #5
nodir1
4 years, 8 months ago (2016-04-22 18:43:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8844a6ee1fa15ee0f12ef34221a79fd3594966b
Cr-Commit-Position: refs/heads/master@{#35635}

Powered by Google App Engine
This is Rietveld 408576698