Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1902163002: Update chromeos_build_instructions for GN and clean up. (Closed)

Created:
4 years, 8 months ago by stevenjb
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update chromeos_build_instructions for GN and clean up. Adds a note for GYP_CHROMIUM_NO_ACTION=1 and includes a bit of cleanup. BUG=none Committed: https://crrev.com/89ee24bb90eeaef13d77175282de565bcfa43a52 Cr-Commit-Position: refs/heads/master@{#388274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M docs/chromeos_build_instructions.md View 3 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
stevenjb
4 years, 8 months ago (2016-04-19 18:30:36 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-19 18:34:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902163002/1
4 years, 8 months ago (2016-04-19 18:37:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 19:26:52 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89ee24bb90eeaef13d77175282de565bcfa43a52
Cr-Commit-Position: refs/heads/master@{#388274}

Powered by Google App Engine
This is Rietveld 408576698