Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1902143002: Adding support for controlling the global sRGB SkColor switch. (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M tools/skiaserve/Request.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/skiaserve/Request.cpp View 3 chunks +7 lines, -0 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/skiaserve/urlhandlers/SRGBModeHandler.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M tools/skiaserve/urlhandlers/UrlHandler.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902143002/1
4 years, 8 months ago (2016-04-19 18:09:20 UTC) #3
Brian Osman
This is the backend support. 2nd review with frontend changes incoming.
4 years, 8 months ago (2016-04-19 18:14:05 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 18:18:51 UTC) #8
ethannicholas
lgtm
4 years, 8 months ago (2016-04-19 19:40:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902143002/1
4 years, 8 months ago (2016-04-19 19:46:58 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 19:47:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/312aa6a81e508f80a46419a14ec842b129ffe563

Powered by Google App Engine
This is Rietveld 408576698