Issue 190213003: Eliminate BrowserThread dependency from WebDataAutofillServiceTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 190213003: Eliminate BrowserThread dependency from WebDataAutofillServiceTest. (Closed)

Created:
6 years, 9 months ago by blundell

Modified:
6 years, 9 months ago

Reviewers:
Jói

CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Eliminate BrowserThread dependency from WebDataAutofillServiceTest. This CL replaces the usage of content::BrowserThread by base::Thread in a straightforward fashion. It also removes now-unneeded includes and DEPS temporary allowances relating to core Autofill test code. BUG=303083 R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255944

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -70 lines)			Patch
M	components/autofill/core/browser/DEPS	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	components/autofill/core/browser/autofill_download_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/autofill_manager_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/autofill_test_utils.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/phone_number_i18n_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/autofill/core/browser/webdata/web_data_service_unittest.cc	View	10 chunks	+17 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blundell

6 years, 9 months ago (2014-03-10 15:18:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r255944 (presubmit successful).

Expand Messages | Collapse Messages