Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1902123005: Use MODIFICATION_TIME in ScanDartTask and ParseHtmlTask. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use MODIFICATION_TIME in ScanDartTask and ParseHtmlTask. Instead of calling AnalysisContext.getModificationStamp() again. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c1475a13a0622547aa17e548c23212b7ca4a87b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -8 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +18 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 3 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/html_test.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-04-20 17:58:05 UTC) #1
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-20 18:11:27 UTC) #2
scheglov
4 years, 8 months ago (2016-04-20 18:14:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1475a13a0622547aa17e548c23212b7ca4a87b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698