Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902113002: [Smart Lock] Fix settings reconciliation on ios. (Closed)

Created:
4 years, 8 months ago by melandory
Modified:
4 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Fix settings reconciliation on ios. BUG=604721 Committed: https://crrev.com/f20000e405ded9b2dcf9d0f6a5bfc0259b251cf8 Cr-Commit-Position: refs/heads/master@{#388452}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
melandory
Hi Vaclav, this patch fix tests upstream, PTAL.
4 years, 8 months ago (2016-04-19 17:50:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902113002/20001
4 years, 8 months ago (2016-04-19 17:51:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 18:35:56 UTC) #5
vabr (Chromium)
lgtm
4 years, 8 months ago (2016-04-20 07:21:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902113002/20001
4 years, 8 months ago (2016-04-20 09:03:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 09:07:01 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:21:53 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f20000e405ded9b2dcf9d0f6a5bfc0259b251cf8
Cr-Commit-Position: refs/heads/master@{#388452}

Powered by Google App Engine
This is Rietveld 408576698