Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1902103003: Update dev_compiler version in DEPS (Closed)

Created:
4 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 8 months ago
Reviewers:
vsm, Paul Berry
CC:
reviews_dartlang.org, Bill Hesse
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 2 chunks +4 lines, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
Siggi Cherem (dart-lang)
/cc Bill - just to let you know that there is a new package `func` ...
4 years, 8 months ago (2016-04-19 21:38:15 UTC) #2
Paul Berry
lgtm
4 years, 8 months ago (2016-04-19 21:40:40 UTC) #3
vsm
lgtm https://codereview.chromium.org/1902103003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1902103003/diff/1/DEPS#newcode184 DEPS:184: (Var("github_dartlang") % "func") + Var("func_rev"), Should this be ...
4 years, 8 months ago (2016-04-19 21:41:32 UTC) #4
Siggi Cherem (dart-lang)
On 2016/04/19 21:41:32, vsm wrote: > lgtm > > https://codereview.chromium.org/1902103003/diff/1/DEPS > File DEPS (right): > ...
4 years, 8 months ago (2016-04-19 21:52:44 UTC) #5
Siggi Cherem (dart-lang)
4 years, 8 months ago (2016-04-19 21:53:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf9ab643cdb27e60497e5529beb059dcb090fbec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698