Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902083002: Remove fullscreen code. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove fullscreen code. The FWL_SetFullScreen() method is never called, remove and all the supporting fullscreen code. Committed: https://pdfium.googlesource.com/pdfium/+/11178284eccf22306338cf0d252b8dbb946feb16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -43 lines) Patch
M xfa/fwl/core/fwl_appimp.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 3 chunks +1 line, -5 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 3 chunks +1 line, -11 lines 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_adapterwidgetmgr.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/ifwl_app.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-19 15:51:27 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-19 17:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902083002/1
4 years, 8 months ago (2016-04-19 17:33:19 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 17:33:35 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/11178284eccf22306338cf0d252b8dbb946f...

Powered by Google App Engine
This is Rietveld 408576698