Performance tweaks for Mojo Dart Controller

Performance tweaks for Mojo Dart Controller

- Enable background compilation in Mojo Dart Controller.
- Disable code write protection

BUG=
R=tonyg@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/8b79a71a2abb8db14ee334101971aaaf323677bf

[Cutch, 2016-04-19 15:38:44]

Description was changed from

==========
Enable background compilation in Mojo Dart Controller

BUG=
==========

to

==========
Performance tweaks for Mojo Dart Controller

- Enable background compilation in Mojo Dart Controller.
- Disable code write protection

BUG=
==========

[Cutch, 2016-04-19 15:38:44]

johnmccutchan@google.com changed reviewers:
+ tonyg@google.com

[tonyg, 2016-04-19 17:00:11]

tonyg@chromium.org changed reviewers:
+ tonyg@chromium.org

[tonyg, 2016-04-19 17:00:11]

lgtm

I verified that a mojo app I'm working on starts up about 15% faster with this
change.

https://codereview.chromium.org/1902053002/diff/20001/mojo/dart/embedder/dart...
File mojo/dart/embedder/dart_controller.cc (right):

https://codereview.chromium.org/1902053002/diff/20001/mojo/dart/embedder/dart...
mojo/dart/embedder/dart_controller.cc:617: // Disable code write protection
I'm not sure what this security implications are of this. Perhaps we should at
least add a big TODO here to revisit once we're interested in locking that stuff
down.

[tonyg, 2016-04-19 17:00:50]

https://codereview.chromium.org/1902053002/diff/20001/mojo/dart/embedder/dart...
File mojo/dart/embedder/dart_controller.cc (right):

https://codereview.chromium.org/1902053002/diff/20001/mojo/dart/embedder/dart...
mojo/dart/embedder/dart_controller.cc:617: // Disable code write protection
On 2016/04/19 17:00:11, tonyg wrote:
> I'm not sure what this security implications are of this. Perhaps we should at
> least add a big TODO here to revisit once we're interested in locking that
stuff
> down.

Also, not related to this patch, but should we set the same in the flutter
embedder?

[Cutch, 2016-04-19 22:09:13]

https://codereview.chromium.org/1902053002/diff/20001/mojo/dart/embedder/dart...
File mojo/dart/embedder/dart_controller.cc (right):

https://codereview.chromium.org/1902053002/diff/20001/mojo/dart/embedder/dart...
mojo/dart/embedder/dart_controller.cc:617: // Disable code write protection
On 2016/04/19 17:00:11, tonyg wrote:
> I'm not sure what this security implications are of this. Perhaps we should at
> least add a big TODO here to revisit once we're interested in locking that
stuff
> down.

Done.

https://codereview.chromium.org/1902053002/diff/20001/mojo/dart/embedder/dart...
mojo/dart/embedder/dart_controller.cc:617: // Disable code write protection
On 2016/04/19 17:00:50, tonyg wrote:
> On 2016/04/19 17:00:11, tonyg wrote:
> > I'm not sure what this security implications are of this. Perhaps we should
at
> > least add a big TODO here to revisit once we're interested in locking that
> stuff
> > down.
> 
> Also, not related to this patch, but should we set the same in the flutter
> embedder?

We should add "--write_protect_code=false" to Flutter too.

[Cutch, 2016-04-19 22:09:29]

Description was changed from

==========
Performance tweaks for Mojo Dart Controller

- Enable background compilation in Mojo Dart Controller.
- Disable code write protection

BUG=
==========

to

==========
Performance tweaks for Mojo Dart Controller

- Enable background compilation in Mojo Dart Controller.
- Disable code write protection

BUG=
R=tonyg@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/8b79a71a2abb8db14ee33410197...
==========

[Cutch, 2016-04-19 22:09:30]

Committed patchset #3 (id:40001) manually as
8b79a71a2abb8db14ee334101971aaaf323677bf (presubmit successful).