Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190203003: Handle has_more correctly in DeveloperPrivateLoadDirectoryFunction (Closed)

Created:
6 years, 9 months ago by hashimoto
Modified:
6 years, 9 months ago
Reviewers:
dvh
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Handle has_more correctly in DeveloperPrivateLoadDirectoryFunction BUG=347900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
hashimoto
6 years, 9 months ago (2014-03-07 09:13:36 UTC) #1
dvh
lgtm.
6 years, 9 months ago (2014-03-07 17:28:59 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-08 04:21:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/190203003/1
6 years, 9 months ago (2014-03-08 11:18:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:13:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234379
6 years, 9 months ago (2014-03-08 14:13:22 UTC) #6
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-08 14:45:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/190203003/1
6 years, 9 months ago (2014-03-08 14:45:41 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 15:40:02 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234423
6 years, 9 months ago (2014-03-08 15:40:02 UTC) #10
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-09 01:58:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/190203003/1
6 years, 9 months ago (2014-03-09 01:58:25 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 02:34:42 UTC) #13
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234683
6 years, 9 months ago (2014-03-09 02:34:42 UTC) #14
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-09 02:52:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/190203003/1
6 years, 9 months ago (2014-03-09 02:52:54 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 03:06:09 UTC) #17
Message was sent while issue was closed. 
Change committed as 255814

Powered by Google App Engine
This is Rietveld 408576698