Issue 1902023003: Mark foregroundLayer under scrollingContentsLayer GraphicsLayerPaintOverflowContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1902023003: Mark foregroundLayer under scrollingContentsLayer GraphicsLayerPaintOverflowContents (Closed)

Created:
4 years, 8 months ago by Xianzhu

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, Rik, jchaffraix+rendering, blink-reviews, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, Stephen Chennney, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, blink-layers+watch_chromium.org, f(malita), danakj+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mark foregroundLayer under scrollingContentsLayer GraphicsLayerPaintOverflowContents Missing the flag made contents of foregroundLayer under scrollingContentsLayer incorrectly applied overflow clip, causing checkboarding during composited scrolling. BUG=599682 Review URL: https://codereview.chromium.org/1895443003 Cr-Commit-Position: refs/heads/master@{#388000}

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -1 line)			Patch
M	third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/GraphicsLayer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

4 years, 8 months ago (2016-04-19 19:45:37 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
4c2f76847759caf477a890159108bcd46e9f2454.

Expand Messages | Collapse Messages