Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902013002: [Interpreter] Pass CompileInfo to BytecodeGenerator's constructor. (Closed)

Created:
4 years, 8 months ago by rmcilroy
Modified:
4 years, 8 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Pass CompileInfo to BytecodeGenerator's constructor. BUG=v8:4280 LOG=N Committed: https://crrev.com/e4d5a446a8688cba379530c38390c4f21a1ffd54 Cr-Commit-Position: refs/heads/master@{#35622}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -34 lines) Patch
M src/interpreter/bytecode-generator.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 3 chunks +14 lines, -25 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902013002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902013002/2
4 years, 8 months ago (2016-04-19 12:00:42 UTC) #2
rmcilroy
As discussed the other day. PTAL, thanks.
4 years, 8 months ago (2016-04-19 12:01:01 UTC) #4
neis
lgtm
4 years, 8 months ago (2016-04-19 12:04:12 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 12:24:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902013002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902013002/2
4 years, 8 months ago (2016-04-19 13:20:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:2)
4 years, 8 months ago (2016-04-19 13:22:25 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 13:23:34 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e4d5a446a8688cba379530c38390c4f21a1ffd54
Cr-Commit-Position: refs/heads/master@{#35622}

Powered by Google App Engine
This is Rietveld 408576698