Issue 19019006: Fix bug in source-maps parsing: parser failed when most information could be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19019006: Fix bug in source-maps parsing: parser failed when most information could be (Closed)

Created:
7 years, 5 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 5 months ago

Reviewers:
dgrove, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bug in source-maps parsing: parser failed when most information could be inferred. This fixes bug http://dartbug.com/11782 R=dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=24981

Patch Set 2 : #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -28 lines)			Patch
M	pkg/source_maps/lib/builder.dart	View		1 chunk	+13 lines, -5 lines	1 comment	Download
M	pkg/source_maps/lib/parser.dart	View	1	4 chunks	+5 lines, -6 lines	0 comments	Download
M	pkg/source_maps/lib/source_maps.dart	View		2 chunks	+15 lines, -16 lines	0 comments	Download
M	pkg/source_maps/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/source_maps/test/common.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	pkg/source_maps/test/end2end_test.dart	View	1	2 chunks	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgrove

lgtm https://codereview.chromium.org/19019006/diff/2001/pkg/source_maps/lib/builder.dart File pkg/source_maps/lib/builder.dart (right): https://codereview.chromium.org/19019006/diff/2001/pkg/source_maps/lib/builder.dart#newcode79 pkg/source_maps/lib/builder.dart:79: // source infromation. information

7 years, 5 months ago (2013-07-12 22:49:20 UTC) #2

Siggi Cherem (dart-lang)

7 years, 5 months ago (2013-07-12 23:14:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24981 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19019006: Fix bug in source-maps parsing: parser failed when most information could be (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages