Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 19019006: Fix bug in source-maps parsing: parser failed when most information could be (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in source-maps parsing: parser failed when most information could be inferred. This fixes bug http://dartbug.com/11782 R=dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=24981

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -28 lines) Patch
M pkg/source_maps/lib/builder.dart View 1 chunk +13 lines, -5 lines 1 comment Download
M pkg/source_maps/lib/parser.dart View 1 4 chunks +5 lines, -6 lines 0 comments Download
M pkg/source_maps/lib/source_maps.dart View 2 chunks +15 lines, -16 lines 0 comments Download
M pkg/source_maps/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/source_maps/test/common.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/source_maps/test/end2end_test.dart View 1 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
6 years, 4 months ago (2013-07-12 21:48:15 UTC) #1
dgrove
lgtm https://codereview.chromium.org/19019006/diff/2001/pkg/source_maps/lib/builder.dart File pkg/source_maps/lib/builder.dart (right): https://codereview.chromium.org/19019006/diff/2001/pkg/source_maps/lib/builder.dart#newcode79 pkg/source_maps/lib/builder.dart:79: // source infromation. information
6 years, 4 months ago (2013-07-12 22:49:20 UTC) #2
Siggi Cherem (dart-lang)
thanks! Done.
6 years, 4 months ago (2013-07-12 23:13:57 UTC) #3
Siggi Cherem (dart-lang)
6 years, 4 months ago (2013-07-12 23:14:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698