Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1901893002: [Media Router WebUI] Simplify search input focus handlers. (Closed)

Created:
4 years, 8 months ago by btolsch
Modified:
4 years, 8 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Simplify search input focus handlers. This change removes some unnecessary variables and focus handlers for the window and search input. BUG=592723 R=apacible@chromium.org Committed: https://crrev.com/67884ed3d9b680286ca9fa2fbc372027cd2b5d0d Cr-Commit-Position: refs/heads/master@{#388172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -71 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 3 chunks +18 lines, -71 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
btolsch
PTAL, thanks!
4 years, 8 months ago (2016-04-18 21:41:53 UTC) #1
apacible
Nice clean up! lgtm
4 years, 8 months ago (2016-04-19 01:38:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901893002/1
4 years, 8 months ago (2016-04-19 01:41:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/52606)
4 years, 8 months ago (2016-04-19 01:54:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901893002/1
4 years, 8 months ago (2016-04-19 09:06:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 09:43:43 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 09:44:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67884ed3d9b680286ca9fa2fbc372027cd2b5d0d
Cr-Commit-Position: refs/heads/master@{#388172}

Powered by Google App Engine
This is Rietveld 408576698