Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1901883002: Make SkImageFilter::Cache purging methods pure virtual (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkImageFilter::Cache purging methods pure virtual This is intended to see if the Windows 10 bots ignoring of the purge methods is a compiler bug. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1901883002 Committed: https://skia.googlesource.com/skia/+/bde57ed11b8a6bd6da6043189e000c58bf146422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/ImageFilterCacheTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
robertphillips
4 years, 8 months ago (2016-04-18 21:19:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901883002/1
4 years, 8 months ago (2016-04-18 21:28:34 UTC) #9
Stephen White
LGTM
4 years, 8 months ago (2016-04-18 21:29:00 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 21:41:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901883002/1
4 years, 8 months ago (2016-04-18 21:49:01 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:50:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bde57ed11b8a6bd6da6043189e000c58bf146422

Powered by Google App Engine
This is Rietveld 408576698