Import supervised user dialog

chrome/browser/resources/md_user_manager/create_profile.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'create-profile' is a page that contains controls for creating
  * a (optionally supervised) profile, including choosing a name, and an avatar.
  */
 (function() {
 /**
@@ skipping 80 matching lines @@
      */
     signedInUserIndex_: {
       type: Number,
       value: NO_USER_SELECTED
     },
 
     /** @private {!signin.ProfileBrowserProxy} */
     browserProxy_: Object
   },
 
+  listeners: {
+    'tap': 'onTap_',
+    'importUserPopup.import': 'onImportUserPopupImport_'
+  },
+
   /** @override */
   created: function() {
     this.browserProxy_ = signin.ProfileBrowserProxyImpl.getInstance();
   },
 
   /** @override */
   ready: function() {
     this.addWebUIListener(
       'create-profile-success', this.handleSuccess_.bind(this));
     this.addWebUIListener(
       'create-profile-warning', this.handleMessage_.bind(this));
     this.addWebUIListener(
       'create-profile-error', this.handleMessage_.bind(this));
     this.addWebUIListener(
       'profile-icons-received', this.handleProfileIcons_.bind(this));
     this.addWebUIListener(
       'profile-defaults-received', this.handleProfileDefaults_.bind(this));
     this.addWebUIListener(
       'signedin-users-received', this.handleSignedInUsers_.bind(this));
 
     this.browserProxy_.getAvailableIcons();
     this.browserProxy_.getSignedInUsers();
 
     // Alias on 'this' to use in html.
     this.NO_USER_SELECTED = NO_USER_SELECTED;
   },
 
   /**
+   * Handles tap events from dynamically created links in warning/error messages
+   * pushed by the browser.
+   * @param {!Event} event
+   * @private
+   */
+  onTap_: function(event) {
+    var element = Polymer.dom(event).rootTarget;
+
+    if (element.id == 'supervised-user-import-existing') {
+      this.onImportUserTap_(event);
+      event.preventDefault();
+    }
+    // TODO(mahmadi): handle tap event on '#reauth' to re-auth the custodian.
+  },
+
+  /**
    * Handler for when the profile icons are pushed from the browser.
    * @param {!Array<string>} iconUrls
    * @private
    */
   handleProfileIcons_: function(iconUrls) {
     this.availableIconUrls_ = iconUrls;
     this.profileIconUrl_ = iconUrls[0];
   },
 
   /**
@@ skipping 26 matching lines @@
   /**
    * Handler for the 'Learn More' link tap event.
    * @param {!Event} event
    * @private
    */
   onLearnMoreTap_: function(event) {
     this.fire('change-page', {page: 'supervised-learn-more-page'});
   },
 
   /**
+   * Handler for the 'Import Supervised User' link tap event.
+   * @param {!Event} event
+   * @private
+   */
+  onImportUserTap_: function(event) {
+    this.createInProgress_ = true;
+
+    if (this.signedInUserIndex_ == NO_USER_SELECTED) {
+      // A custodian must be selected.
+      this.handleMessage_(this.i18n('custodianAccountNotSelectedError'));
+      this.createInProgress_ = false;

[Dan Beam, 2016/04/20 22:38:55]

it's odd that createInProgress_ is set to true then (possibly) immediately to
false

[Moe, 2016/04/21 17:32:30]

It is indeed. I moved all instances of "this.createInProgress_ = true;" right
next to the appropriate this.browserProxy_ calls to avoid cases like this.

+    } else {
+      var signedInUser = this.signedInUser_(this.signedInUserIndex_);
+      this.browserProxy_.getExistingSupervisedUsers(
+          signedInUser.profilePath).then(
+              this.showImportSupervisedUserPopup_.bind(this),
+              /** @param {*} error */
+              function(error) { this.handleMessage_(error); }.bind(this));

[Dan Beam, 2016/04/20 22:38:55]

can we just update handleMessage_ to take an {Error|string} (or {*}) so this
code (and below) could be:

  this.browserProxy_.getExistingSupervisedUsers(signedInUser.profilePath).then(
      this.showImportSupervisedUserPopup_.bind(this),
      this.handleMessage_.bind(this));

[Moe, 2016/04/21 17:32:30]

Done. The catch is there'll be type cast needed here:

this.message_ =  /** @type {string} */ (message);

[Dan Beam, 2016/04/22 01:25:30]

could we just make it a real string?

  this.message_ = '' + message;

[Moe, 2016/04/22 18:46:04]

Done.

+    }
+  },
+
+  /**
    * Handler for the 'Save' button tap event.
    * @param {!Event} event
    * @private
    */
   onSaveTap_: function(event) {
     this.createInProgress_ = true;
 
     if (!this.isSupervised_) {
       // The new profile is not supervised. Go ahead and create it.
       this.createProfile_();
     } else if (this.signedInUserIndex_ == NO_USER_SELECTED) {
       // If the new profile is supervised, a custodian must be selected.
       this.handleMessage_(this.i18n('custodianAccountNotSelectedError'));
       this.createInProgress_ = false;
     } else {
       var signedInUser = this.signedInUser_(this.signedInUserIndex_);
       this.browserProxy_.getExistingSupervisedUsers(
           signedInUser.profilePath).then(
             this.createProfileIfValidSupervisedUser_.bind(this),
             /** @param {*} error */
             function(error) { this.handleMessage_(error); }.bind(this));
     }
   },
 
   /**
+   * Displays the import supervised user popup.
+   * @param {Array<SupervisedUser>} supervisedUsers The list of existing
+   *     supervised users.
+   * @private
+   */
+  showImportSupervisedUserPopup_: function(supervisedUsers) {
+    this.createInProgress_ = false;
+    this.$.importUserPopup.show(this.signedInUser_(this.signedInUserIndex_),
+                                supervisedUsers);
+  },
+
+  /**
    * Checks if the entered name matches name of an existing supervised user.
    * If yes, the user is prompted to import the existing supervised user.
    * If no, the new supervised profile gets created.
    * @param {Array<SupervisedUser>} supervisedUsers The list of existing
    *     supervised users.
    * @private
    */
   createProfileIfValidSupervisedUser_: function(supervisedUsers) {
     for (var i = 0; i < supervisedUsers.length; ++i) {
       if (supervisedUsers[i].name != this.profileName_)
@@ skipping 32 matching lines @@
    * @private
    */
   createProfile_: function() {
     var custodianProfilePath = '';
     if (this.signedInUserIndex_ != NO_USER_SELECTED) {
       custodianProfilePath =
           this.signedInUser_(this.signedInUserIndex_).profilePath;
     }
 
     this.browserProxy_.createProfile(
-        this.profileName_, this.profileIconUrl_, this.isSupervised_,
+        this.profileName_, this.profileIconUrl_, this.isSupervised_, '',
         custodianProfilePath);
   },
 
   /**
+   * Handler for the 'import' event fired by #importUserPopup once a supervised
+   * user is selected to be imported and the popup closes.
+   * @param {!{detail: {supervisedUser: !SupervisedUser,
+                        signedInUser: !SignedInUser}}} event

[Dan Beam, 2016/04/20 22:38:55]

nit: this row needs a * at the start

[Moe, 2016/04/21 17:32:30]

Done.

+   * @private
+   */
+  onImportUserPopupImport_: function(event) {
+    this.createInProgress_ = true;
+    var supervisedUser = event.detail.supervisedUser;
+    var signedInUser = event.detail.signedInUser;
+    this.browserProxy_.createProfile(
+        supervisedUser.name, supervisedUser.iconURL, true, supervisedUser.id,
+        signedInUser.profilePath);
+  },
+
+  /**
    * Handler for the 'Cancel' button tap event.
    * @param {!Event} event
    * @private
    */
   onCancelTap_: function(event) {
     if (this.createInProgress_) {
       this.createInProgress_ = false;
       this.browserProxy_.cancelCreateProfile();
     } else {
       this.fire('change-page', {page: 'user-pods-page'});
@@ skipping 34 matching lines @@
   },
 
   /**
    * Handles profile create/import warning/error message pushed by the browser.
    * @param {string} message An HTML warning/error message.
    * @private
    */
   handleMessage_: function(message) {
     this.createInProgress_ = false;
     this.message_ = message;
-
-    // TODO(mahmadi): attach handler to '#supervised-user-import-existing'
-    // in order to import supervised user with the given name.
-
-    // TODO(mahmadi): attach handler to '#reauth' in order to re-authenticate
-    // custodian.
   },
 
   /**
    * Computed binding determining which profile icon button is toggled on.
    * @param {string} iconUrl icon URL of a given icon button.
    * @param {string} profileIconUrl Currently selected icon URL.
    * @return {boolean}
    * @private
    */
   isActiveIcon_: function(iconUrl, profileIconUrl) {
     return iconUrl == profileIconUrl;
   },
 
   /**
    * Computed binding determining whether 'Save' button is disabled.
    * @param {boolean} createInProgress Is create in progress?
    * @param {string} profileName Profile Name.
    * @return {boolean}
    * @private
    */
   isSaveDisabled_: function(createInProgress, profileName) {
     // TODO(mahmadi): Figure out a way to add 'paper-input-extracted' as a
     // dependency and cast to PaperInputElement instead.
     /** @type {{validate: function():boolean}} */
     var nameInput = this.$.nameInput;
     return createInProgress || !profileName || !nameInput.validate();
   },
 
   /**
+   * Returns True if the import supervised user link should be hidden.
+   * @param {boolean} createInProgress True if create/import is in progress
+   * @param {number} signedInUserIndex Index of the selected signed-in user.
+   * @return {boolean}
+   * @private
+   */
+  isImportUserLinkHidden_: function(createInProgress, signedInUserIndex) {
+    return createInProgress || !this.signedInUser_(signedInUserIndex);
+  },
+
+  /**
    * Computed binding that returns True if there are any signed-in users.
    * @param {!Array<!SignedInUser>} signedInUsers signed-in users.
    * @return {boolean}
    * @private
    */
   isSignedIn_: function(signedInUsers) {
     return signedInUsers.length > 0;
   }
 });
 }());