Import supervised user dialog

chrome/browser/resources/md_user_manager/create_profile.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'create-profile' is a page that contains controls for creating
  * a (optionally supervised) profile, including choosing a name, and an avatar.
  */
 (function() {
 /**
@@ skipping 80 matching lines @@
      */
     signedInUserIndex_: {
       type: Number,
       value: NO_USER_SELECTED
     },
 
     /** @private {!signin.ProfileBrowserProxy} */
     browserProxy_: Object
   },
 
+  listeners: {
+    'tap': 'onTap_'

[tommycli, 2016/04/18 23:27:18]

This is leftover right?

[Moe, 2016/04/19 21:47:42]

No it is not. Unfortunately, this is another i18n messages with links issue. We
have at least two error messages with link in them. This handler is meant to
handle tap events on those. 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20S...
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20S...

[Dan Beam, 2016/04/19 23:41:57]

bummer, you can't do supervised-user-import-existing.tap because the element is
dynamically added :(

https://www.polymer-project.org/1.0/docs/devguide/events.html#event-listeners

[Moe, 2016/04/20 15:28:56]

totally!

+  },
+
   /** @override */
   created: function() {
     this.browserProxy_ = signin.ProfileBrowserProxyImpl.getInstance();
   },
 
   /** @override */
   ready: function() {
     this.addWebUIListener(
       'create-profile-success', this.handleSuccess_.bind(this));
     this.addWebUIListener(
       'create-profile-warning', this.handleMessage_.bind(this));
     this.addWebUIListener(
       'create-profile-error', this.handleMessage_.bind(this));
     this.addWebUIListener(
       'profile-icons-received', this.handleProfileIcons_.bind(this));
     this.addWebUIListener(
       'profile-defaults-received', this.handleProfileDefaults_.bind(this));
     this.addWebUIListener(
       'signedin-users-received', this.handleSignedInUsers_.bind(this));
 
     this.browserProxy_.getAvailableIcons();
     this.browserProxy_.getSignedInUsers();
 
     // Alias on 'this' to use in html.
     this.NO_USER_SELECTED = NO_USER_SELECTED;
   },
 
   /**
+   * General handler for tap event on the host, used to handle tap events for
+   * dynamically added '<a>' elements.
+   * @param {!Event} event
+   * @private
+   */
+  onTap_: function(event) {

[tommycli, 2016/04/18 23:27:18]

This is also a leftover right? I don't see any dynamically created <a> elements.

[Moe, 2016/04/19 21:47:42]

Please see the previous response.

[tommycli, 2016/04/19 23:33:37]

This is unfortunate but ... -- this is pretty dirty but I don't have a concrete
alternative suggestion.

Just remember to preventDefault on the event then.

[Dan Beam, 2016/04/19 23:41:57]

this is not dirty, it's event delegation

[Moe, 2016/04/20 15:28:56]

Done.

+    var element = Polymer.dom(event).rootTarget;
+
+    // Handle the tap event only if the target is a '<a>' element.
+    if (element.nodeName == 'A') {

[Dan Beam, 2016/04/19 23:41:57]

you should never need to filter by nodeName if you have an ID

[Moe, 2016/04/20 15:28:56]

Done.

+      if (element.id == 'supervised-user-import-existing') {

[Dan Beam, 2016/04/19 23:41:57]

no curlies

[Moe, 2016/04/20 15:28:56]

Done.

+        this.onImportUserTap_(event);
+      }
+      // TODO(mahmadi): handle tap event on '#reauth' to re-auth the custodian.
+    }
+  },
+
+  /**
    * Handler for when the profile icons are pushed from the browser.
    * @param {!Array<string>} iconUrls
    * @private
    */
   handleProfileIcons_: function(iconUrls) {
     this.availableIconUrls_ = iconUrls;
     this.profileIconUrl_ = iconUrls[0];
   },
 
   /**
@@ skipping 26 matching lines @@
   /**
    * Handler for the 'Learn More' link tap event.
    * @param {!Event} event
    * @private
    */
   onLearnMoreTap_: function(event) {
     this.fire('change-page', {page: 'supervised-learn-more-page'});
   },
 
   /**
+   * Handler for the 'Import Supervised User' link tap event.
+   * @param {!Event} event
+   * @private
+   */
+  onImportUserTap_: function(event) {
+    this.createInProgress_ = true;
+
+    if (this.signedInUserIndex_ == NO_USER_SELECTED) {
+      // A custodian must be selected.
+      this.handleMessage_(this.i18n('custodianAccountNotSelectedError'));
+      this.createInProgress_ = false;
+    } else {
+      var signedInUser = this.signedInUser_(this.signedInUserIndex_);
+      this.browserProxy_.getExistingSupervisedUsers(
+          signedInUser.profilePath).then(
+              this.showImportSupervisedUserPopup_.bind(this),
+              /** @param {*} error */
+              function(error) { this.handleMessage_(error); }.bind(this));
+    }
+  },
+
+  /**
    * Handler for the 'Save' button tap event.
    * @param {!Event} event
    * @private
    */
   onSaveTap_: function(event) {
     this.createInProgress_ = true;
 
     if (!this.isSupervised_) {
       // The new profile is not supervised. Go ahead and create it.
       this.createProfile_();
     } else if (this.signedInUserIndex_ == NO_USER_SELECTED) {
       // If the new profile is supervised, a custodian must be selected.
       this.handleMessage_(this.i18n('custodianAccountNotSelectedError'));
       this.createInProgress_ = false;
     } else {
       var signedInUser = this.signedInUser_(this.signedInUserIndex_);
       this.browserProxy_.getExistingSupervisedUsers(
           signedInUser.profilePath).then(
             this.createProfileIfValidSupervisedUser_.bind(this),
             /** @param {*} error */
             function(error) { this.handleMessage_(error); }.bind(this));
     }
   },
 
   /**
+   * Displays the import supervised user popup.
+   * @param {Array<SupervisedUser>} supervisedUsers The list of existing
+   *     supervised users.
+   * @private
+   */
+  showImportSupervisedUserPopup_: function(supervisedUsers) {
+    this.createInProgress_ = false;
+    this.$.importUserPopup.show(this.signedInUser_(this.signedInUserIndex_),
+                                supervisedUsers);
+  },
+
+  /**
    * Checks if the entered name matches name of an existing supervised user.
    * If yes, the user is prompted to import the existing supervised user.
    * If no, the new supervised profile gets created.
    * @param {Array<SupervisedUser>} supervisedUsers The list of existing
    *     supervised users.
    * @private
    */
   createProfileIfValidSupervisedUser_: function(supervisedUsers) {
     for (var i = 0; i < supervisedUsers.length; ++i) {
       if (supervisedUsers[i].name != this.profileName_)
@@ skipping 32 matching lines @@
    * @private
    */
   createProfile_: function() {
     var custodianProfilePath = '';
     if (this.signedInUserIndex_ != NO_USER_SELECTED) {
       custodianProfilePath =
           this.signedInUser_(this.signedInUserIndex_).profilePath;
     }
 
     this.browserProxy_.createProfile(
-        this.profileName_, this.profileIconUrl_, this.isSupervised_,
+        this.profileName_, this.profileIconUrl_, this.isSupervised_, '',
         custodianProfilePath);
   },
 
   /**
+   * Handler for the 'import-supervised-user' element's import event.

[tommycli, 2016/04/18 23:27:18]

Maybe update the comment to elucidate more that this is what happens after the
importUserPopup finishes.

[Moe, 2016/04/19 21:47:42]

Done.

+   * @param {!{detail: {supervisedUser: !SupervisedUser,
+                        signedInUser: !SignedInUser}}} event
+   * @private
+   */
+  onImportUserPopupImport_: function(event) {
+    this.createInProgress_ = true;
+    var supervisedUser = event.detail.supervisedUser;
+    var signedInUser = event.detail.signedInUser;
+    this.browserProxy_.createProfile(
+        supervisedUser.name, supervisedUser.iconURL, true, supervisedUser.id,
+        signedInUser.profilePath);
+  },
+
+  /**
    * Handler for the 'Cancel' button tap event.
    * @param {!Event} event
    * @private
    */
   onCancelTap_: function(event) {
     if (this.createInProgress_) {
       this.createInProgress_ = false;
       this.browserProxy_.cancelCreateProfile();
     } else {
       this.fire('change-page', {page: 'user-pods-page'});
@@ skipping 34 matching lines @@
   },
 
   /**
    * Handles profile create/import warning/error message pushed by the browser.
    * @param {string} message An HTML warning/error message.
    * @private
    */
   handleMessage_: function(message) {
     this.createInProgress_ = false;
     this.message_ = message;
-
-    // TODO(mahmadi): attach handler to '#supervised-user-import-existing'
-    // in order to import supervised user with the given name.
-
-    // TODO(mahmadi): attach handler to '#reauth' in order to re-authenticate
-    // custodian.
   },
 
   /**
    * Computed binding determining which profile icon button is toggled on.
    * @param {string} iconUrl icon URL of a given icon button.
    * @param {string} profileIconUrl Currently selected icon URL.
    * @return {boolean}
    * @private
    */
   isActiveIcon_: function(iconUrl, profileIconUrl) {
     return iconUrl == profileIconUrl;
   },
 
   /**
    * Computed binding determining whether 'Save' button is disabled.
    * @param {boolean} createInProgress Is create in progress?
    * @param {string} profileName Profile Name.
    * @return {boolean}
    * @private
    */
   isSaveDisabled_: function(createInProgress, profileName) {
     // TODO(mahmadi): Figure out a way to add 'paper-input-extracted' as a
     // dependency and cast to PaperInputElement instead.
     /** @type {{validate: function():boolean}} */
     var nameInput = this.$.nameInput;
     return createInProgress || !profileName || !nameInput.validate();
   },
 
   /**
+   * Returns True if the import supervised user link should be hidden.
+   * @param {boolean} createInProgress True if create/import is in progress
+   * @param {number} signedInUserIndex Index of the selected signed-in user.
+   * @return {boolean}
+   * @private
+   */
+  isImportUserLinkHidden_: function(createInProgress, signedInUserIndex) {
+    return createInProgress || !this.signedInUser_(signedInUserIndex);

[tommycli, 2016/04/18 23:27:18]

Interesting... the link is really hidden as soon as the user clicks it? The
mocks specify that?

[Moe, 2016/04/19 21:47:42]

I checked with UX. The same thing as the create scenario should happen here.
Loading the custodian account could take some time. In meantime, we disable the
"Save" button and hide "Import an existing supervised user" link.

+  },
+
+  /**
    * Computed binding that returns True if there are any signed-in users.
    * @param {!Array<!SignedInUser>} signedInUsers signed-in users.
    * @return {boolean}
    * @private
    */
   isSignedIn_: function(signedInUsers) {
     return signedInUsers.length > 0;
   }
 });
 }());